Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dynamic line heights using decorations #194609

Closed
wants to merge 13 commits into from
Closed

Support dynamic line heights using decorations #194609

wants to merge 13 commits into from

Commits on Oct 2, 2023

  1. Support dynamic line heights using decorations

    @remcohaszing
    remcohaszing committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    7495b2b View commit details
    Browse the repository at this point in the history

  2. Remove unrelated changes

    @remcohaszing
    remcohaszing committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    ef965b9 View commit details
    Browse the repository at this point in the history

  3. Use new view-overlay CSS class

    @remcohaszing
    remcohaszing committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    43b3b2d View commit details
    Browse the repository at this point in the history

  4. Fix updating lines when typing

    @remcohaszing
    remcohaszing committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    8b91aa6 View commit details
    Browse the repository at this point in the history

  5. Remove dead code

    @remcohaszing
    remcohaszing committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    39780a2 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Cache the result of getDecorationsLineHeightMap

    @remcohaszing
    remcohaszing committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    dea51bd View commit details
    Browse the repository at this point in the history

  2. Fix typos

    @remcohaszing
    remcohaszing committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    1b12219 View commit details
    Browse the repository at this point in the history

  3. Use Uint8ClampedArray to store line heights 

    This limits the maximum line height to 255, which seems sufficient.
    @remcohaszing
    remcohaszing committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    3ecbefa View commit details
    Browse the repository at this point in the history

  4. Fix some line height related calculations

    @remcohaszing
    remcohaszing committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    aeb769e View commit details
    Browse the repository at this point in the history

  5. Fix scrolling issues

    @remcohaszing
    remcohaszing committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    e39c2a8 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Fix the cursor position

    @remcohaszing
    remcohaszing committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    69e6125 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Make text wrapping decorations full height 

    This applies to selected text, search highlight, and same word
highlight, and other forms of highlighting.
    @remcohaszing
    remcohaszing committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    b71e45f View commit details
    Browse the repository at this point in the history

  2. Handle line wrapping

    @remcohaszing
    remcohaszing committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    198c3b6 View commit details
    Browse the repository at this point in the history