Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizes the tab size when dirty file state changes, fixes #15364 #19976

Merged
merged 1 commit into from
Feb 8, 2017

Conversation

reaktivo
Copy link
Contributor

@reaktivo reaktivo commented Feb 5, 2017

Is it desirable still keep the minimum tab width to 120px? Looks like it used to not have a minimum width and it was added recently.

@mention-bot
Copy link

@reaktivo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero to be a potential reviewer.

@msftclas
Copy link

msftclas commented Feb 5, 2017

Hi @reaktivo, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@bpasero bpasero self-assigned this Feb 5, 2017
@bpasero
Copy link
Member

bpasero commented Feb 6, 2017

@reaktivo looks cool and works cool but hard to tell if people actually want this. I can see that it helps reduce the actual width of tabs but it also adds some visual noise to the overall behaviour.

Maybe you could follow up with the original group of people that wanted to have the close button hidden to see if this is desired. That discussion is in #10739

@reaktivo
Copy link
Contributor Author

reaktivo commented Feb 7, 2017

I see there was no mention of tab size in the discussion at #10739. Although I though it might be useful considering #15364 was still open. You can reject this one.

@bpasero
Copy link
Member

bpasero commented Feb 7, 2017

@reaktivo I am just very sensitive about changing something in this area without hearing from real users that actually have tab button disabled.

@reaktivo
Copy link
Contributor Author

reaktivo commented Feb 7, 2017

@bpasero I understand, I can come back to this issue if there's interest.

@bpasero
Copy link
Member

bpasero commented Feb 7, 2017

Thanks

@bpasero bpasero merged commit d147559 into microsoft:master Feb 8, 2017
@bpasero
Copy link
Member

bpasero commented Feb 8, 2017

@reaktivo let's just merge this in and wait for reactions 👍

@bpasero bpasero added this to the February 2017 milestone Feb 8, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants