Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #944 - Support wildcards on activationEvents.workspaceContains #24570

Merged
merged 3 commits into from
May 29, 2017

Conversation

eamodio
Copy link
Contributor

@eamodio eamodio commented Apr 12, 2017

Here is a first pass at this -- I don't really like checking for wildcard/glob characters but it works as is and should be easy enough to change that part if the rest looks reasonable.

@mention-bot
Copy link

@eamodio, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero and @alexandrudima to be potential reviewers.

@eamodio
Copy link
Contributor Author

eamodio commented Apr 25, 2017

@alexandrudima I'm not sure why the builds are failing with these changes -- it builds locally. And looking at the travis one, I don't even see any failures. Any ideas?

@eamodio eamodio force-pushed the feature-wildcard-workspaceContains branch from 1001192 to 10c0610 Compare April 27, 2017 05:45
@eamodio
Copy link
Contributor Author

eamodio commented Apr 27, 2017

Apparently it just needed a kick

@eamodio
Copy link
Contributor Author

eamodio commented May 9, 2017

Any chance this could be looked at in the May iteration? I know the C# extension is really hoping to get this in.

@eamodio
Copy link
Contributor Author

eamodio commented May 29, 2017

@alexandrudima sorry to bother you, but any feedback on this?

@alexdima alexdima merged commit b498ac0 into microsoft:master May 29, 2017
@alexdima
Copy link
Member

@eamodio Thank you for your contribution! ❤️

@chrmarti @roblourens @jrieken fyi

@alexdima alexdima added this to the May 2017 milestone May 29, 2017
@eamodio
Copy link
Contributor Author

eamodio commented May 29, 2017

@alexandrudima awesome! thank you!

@jens1o
Copy link
Contributor

jens1o commented May 29, 2017

Thanks, very cool!

@eamodio eamodio deleted the feature-wildcard-workspaceContains branch May 30, 2017 07:12
@roblourens
Copy link
Member

Future improvement: This will run until the entire workspace has been searched, even if it finds a match immediately. You could use the progress callback on search to complete immediately once a match is found.

@eamodio
Copy link
Contributor Author

eamodio commented May 30, 2017

@roblourens doesn't this https:/Microsoft/vscode/pull/24570/files#diff-7799696b0b4988cc737acff368fad1b1R140 make it return after the first match?

@roblourens
Copy link
Member

Oh right, yes :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants