Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added config option git.cloneDirectory, defaulting to os.homedir() #24950

Merged
merged 2 commits into from
May 4, 2017
Merged

added config option git.cloneDirectory, defaulting to os.homedir() #24950

merged 2 commits into from
May 4, 2017

Conversation

ihalip
Copy link
Contributor

@ihalip ihalip commented Apr 18, 2017

Fixes #17671.

Added a new option called git.cloneDirectory, to be used as the base path for the git.clone command. When it is not set by the user, it will use the current default - os.homedir().

@mention-bot
Copy link

@ihalip, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joaomoreno and @egamma to be potential reviewers.

@msftclas
Copy link

@ihalip,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@joaomoreno joaomoreno added this to the May 2017 milestone Apr 18, 2017
@joaomoreno joaomoreno self-requested a review April 18, 2017 12:30
@joaomoreno joaomoreno self-assigned this Apr 18, 2017
@joaomoreno
Copy link
Member

Thanks! 🍻

Changed the setting to git.defaultCloneDirectory.

@joaomoreno joaomoreno merged commit db42080 into microsoft:master May 4, 2017
joaomoreno added a commit that referenced this pull request May 4, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git Clone: Default clone into /tmp folder
4 participants