Inserting file path on the terminal, when dragging a file to it #24951
Conversation
|
@jportela, It will cover your contributions to all Microsoft-managed open source projects. |
|
@jportela, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
|
Thanks for this @jportela, just tested out the code and noticed the following (mac):
The main actions so far are:
|
|
Windows seems to work fine, apart from the path needing the to be wrapped in "" when it contains spaces 👍 |
| return; | ||
| } | ||
| const url = e.dataTransfer.getData('URL'); | ||
| const filePath = this._getPathFromUrl(url); |
There was a problem hiding this comment.
Instead of doing this you should use Uri.file(path), you should then be able to extract the path in the correct format from that class. https:/Microsoft/vscode/blob/d02567a2e43203f20d4a1daf1ca7c489be033a4b/src/vs/base/common/uri.ts#L215
jportela
force-pushed
the
terminal-paste-path
branch
from
c61edae
to
b1d30b8
Compare
jportela
force-pushed
the
terminal-paste-path
branch
from
b1d30b8
to
ea4e0f4
Compare
|
@Tyriar thanks for noticing those cases and showing me the URI utility. I think now they are OK:
|
|
@jportela sorry about the delay, bit busy with release stuff atm. I hope to get this in for May 😃 |
|
@jportela sorry about the delay. This is great, thanks a lot 😄 should be included 1.13 🎆 |
This feature was suggested in #11907
I've tested the following scenarios, on a MacOS device:
Let me know if any change is needed