Detect more def* forms in Clojure syntax #25546
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s a convention in Clojure to use macros whose name starts with
def
to define something. Libraries often define their own custom macros for this:defroutes
(Compojure)defc
(Rum)This is why whitelisting only def macros from clojure.core isn’t working: it will detect standard vars and functions but will fail to detect custom
def*
-like macros.This PR adds regular expression that treats all forms whose name starts with
def
(with optional namespace) similarly.This convention is very well established so it shouldn’t hurt anyone.