Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing duplicate tab close when doing a middle click #25697

Closed
wants to merge 1 commit into from

Conversation

jportela
Copy link
Contributor

Fixes #25529

@mention-bot
Copy link

@jportela, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero and @jrieken to be potential reviewers.

@msftclas
Copy link

@jportela,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@bpasero bpasero modified the milestones: April 2017, May 2017 Apr 30, 2017
@bpasero bpasero self-assigned this May 1, 2017
@bpasero
Copy link
Member

bpasero commented May 2, 2017

@jportela thanks, I was accidentally already working on a solution for this one, but did not push. My solution reuses the same code we had already to detect this case (see 35a12c9).

Nevertheless I will make sure that you get mentioned in the credits file for the May release notes 👍

@bpasero bpasero closed this May 2, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing a tab using middle mouse button on the 'x' causes the tab to the right to also be clsosed
4 participants