Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix php function highlight #26543

Closed
wants to merge 2 commits into from
Closed

Fix php function highlight #26543

wants to merge 2 commits into from

Conversation

luxifer
Copy link
Contributor

@luxifer luxifer commented May 12, 2017

According to http://php.net/manual/en/functions.user-defined.php extended ascii is allowed in function name such as non breaking space (\xa0).

@mention-bot
Copy link

@luxifer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima to be a potential reviewer.

@msftclas
Copy link

@luxifer,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link

@luxifer, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@aeschli
Copy link
Contributor

aeschli commented May 12, 2017

Thanks @luxifer!
The PHP grammar that we use is from https:/atom/language-php and we want to avoid having our fork. Would you mind make the PR there? Once accepted there, please ping me and I'm happy to run our update script.

@aeschli aeschli closed this May 12, 2017
@luxifer
Copy link
Contributor Author

luxifer commented May 12, 2017

see atom/language-php#196

@luxifer
Copy link
Contributor Author

luxifer commented May 12, 2017

If you want, when you have updated the grammar I can submit another PR with only the tests to ensure the new grammar works

@luxifer
Copy link
Contributor Author

luxifer commented May 15, 2017

@aeschli the PR on atom has been merged

@aeschli
Copy link
Contributor

aeschli commented May 18, 2017

@luxifer I updated the grammar. Thanks a lot!

aeschli added a commit that referenced this pull request May 18, 2017
@luxifer
Copy link
Contributor Author

luxifer commented May 18, 2017 via email

@aeschli aeschli added this to the May 2017 milestone May 19, 2017
@aeschli
Copy link
Contributor

aeschli commented May 19, 2017

@luxifer Yes

@luxifer
Copy link
Contributor Author

luxifer commented May 20, 2017

Here's the pull request with only the tests #26992

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants