Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lua function colorizing error #26880

Closed
wants to merge 1 commit into from
Closed

Fix lua function colorizing error #26880

wants to merge 1 commit into from

Conversation

actboy168
Copy link

function mt:x(a, b) end
function mt1:x(a, b) end
function(a, b) end
function (a, b) end

Before
2

After
1

e.g.
```lua
function mt:x(a, b) end
function mt1:x(a, b) end
function(a, b) end
function (a, b) end
```
@msftclas
Copy link

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@aeschli
Copy link
Contributor

aeschli commented May 22, 2017

We use the grammar from https:/textmate/lua.tmbundle. Would you mind also create a PR there?

@actboy168
Copy link
Author

Do you mean that textmate/lua.tmbundle#7 ?

It looks like this is a nobody to maintain the project.

@aeschli
Copy link
Contributor

aeschli commented May 25, 2017

textmate/lua.tmbundle#7 has been fixed and I update the lua grammar in VSCode. I verified your example works.

@aeschli aeschli closed this May 25, 2017
@aeschli aeschli added this to the May 2017 milestone May 25, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants