-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose status bar debugging and no-folder foreground colors. #27052
Conversation
@smoogipooo, It will cover your contributions to all Microsoft-managed open source projects. |
@smoogipooo, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, some feedback provided.
src/vs/workbench/common/theme.ts
Outdated
@@ -118,6 +118,12 @@ export const STATUS_BAR_FOREGROUND = registerColor('statusBar.foreground', { | |||
hc: '#FFFFFF' | |||
}, nls.localize('statusBarForeground', "Status bar foreground color. The status bar is shown in the bottom of the window.")); | |||
|
|||
export const STATUS_BAR_NO_FOLDER_FOREGROUND = registerColor('statusBar.noFolderForeground', { | |||
dark: '#FFFFFF', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to use STATUS_BAR_FOREGROUND
here as default color for all themes instead of specifying the color again as FFFFFF
. This makes sure that all existing themes are not broken that specify STATUS_BAR_FOREGROUND
any different from FFFFFF
.
@@ -20,6 +20,12 @@ export const STATUS_BAR_DEBUGGING_BACKGROUND = registerColor('statusBar.debuggin | |||
hc: '#CC6633' | |||
}, localize('statusBarDebuggingBackground', "Status bar background color when a program is being debugged. The status bar is shown in the bottom of the window")); | |||
|
|||
export const STATUS_BAR_DEBUGGING_FOREGROUND = registerColor('statusBar.debuggingForeground', { | |||
dark: '#FFFFFF', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, use STATUS_BAR_FOREGROUND
as default
return STATUS_BAR_DEBUGGING_BACKGROUND; | ||
} | ||
|
||
private getForegroundColorKey(): string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks almost identical to getBackgroundColorKey
. Can we just have one method where all color keys are passed in? Something like getColorKey(noFolderColor, debuggingColor, normalColor)
?
…d-colors # Conflicts: # src/vs/workbench/browser/parts/statusbar/statusbarPart.ts
@smoogipooo thanks, there is a bigger issue though which I am not sure how to solve: If you search for We need a way to carry over the colors to those places but without introducing a dependency to debug. I think this needs a different solution. |
Closing temporarily pending changes since I don't know how much time I have to work on this over the next few days. |
@smoogipooo I took your PR as starting point and did the necessary changes on top to make this work with debugging: 1281eab I added you to the release notes for our upcoming release to attribute your PR. |
Just being able to change the foreground color may not be enough in cases where the background color is radically different.