Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional sortByLabel to QuickPick to control whether to re-sort results #77297

Closed
wants to merge 2 commits into from

Commits on Jul 12, 2019

  1. Add optional sortByLabel to QuickPick to control whether to re-sort i…

    …tems when query changes
    
    Summary:
    Address issue microsoft#73904 by adding an optional `sortByLabel` to the QuickPick class which determines whether the picker re-sorts the result list when the user types in the input field.
    
    If true, the picker applies a sort to order results by the index of the first appearance of the input in the label.
    
    For backwards compatibility, this field is true by default.
    
    microsoft#73904
    
    Test Plan:
    attached video shows behavior both before and after
    
    {F167292605}
    
    note: there aren't any existing tests on what happens when the query input changes in the QuickPick
    
    Reviewers: dalongi, ericblue, hchau
    
    Reviewed By: ericblue
    
    Differential Revision: https://phabricator.intern.facebook.com/D16203434
    
    Signature: 16203434:1562878837:5413e3852f2bd04c8e81b9fe5c4a08127dfe3b65
    pelmers committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    4ada92f View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2019

  1. Move sortByLabel to proposed API

    Summary: API additions should start off in the proposed API file.
    
    Test Plan:
    same as before, tested that I could skip sorting:
    {F168164535}
    
    Reviewers: dalongi, ericblue, hchau
    
    Reviewed By: ericblue
    
    Differential Revision: https://phabricator.intern.facebook.com/D16264910
    
    Signature: 16264910:1563214616:55ecf86a9d4a0d8a0cd44d9b33eb770b2a7d04aa
    pelmers committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    f766405 View commit details
    Browse the repository at this point in the history