Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(site): update otel.md #2821

Merged
merged 1 commit into from
Mar 27, 2023
Merged

docs(site): update otel.md #2821

merged 1 commit into from
Mar 27, 2023

Conversation

waitingsong
Copy link
Member

NodeSDK.start() become synchronous

ref: open-telemetry/opentelemetry-js#3460

`NodeSDK.start()` become `synchronous`

ref: open-telemetry/opentelemetry-js#3460
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.16 ⚠️

Comparison is base (7ad4e9b) 82.14% compared to head (41823c3) 81.98%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2821      +/-   ##
==========================================
- Coverage   82.14%   81.98%   -0.16%     
==========================================
  Files         427      427              
  Lines       15245    15245              
  Branches     3604     3604              
==========================================
- Hits        12523    12499      -24     
- Misses       2473     2492      +19     
- Partials      249      254       +5     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czy88840616 czy88840616 enabled auto-merge (squash) March 27, 2023 06:15
@czy88840616 czy88840616 merged commit 4c9e56b into midwayjs:main Mar 27, 2023
@waitingsong waitingsong deleted the otel branch March 27, 2023 08:20
czy88840616 pushed a commit that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants