Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @MainApp() decorator and remove framework type support #4119

Merged
merged 7 commits into from
Oct 11, 2024

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@czy88840616 czy88840616 added the pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. label Oct 11, 2024
@czy88840616 czy88840616 changed the base branch from main to v4-next October 11, 2024 03:23
@waitingsong
Copy link
Member

减少框架平台类型?

@czy88840616
Copy link
Member Author

czy88840616 commented Oct 11, 2024

把 MidwayFrameworkType 字段去了,MidwayFrameworkType 没法自定义,enum 也不能很简单的扩展。

@czy88840616 czy88840616 changed the title refactor: remove framework type support feat: add @MainApp() decorator and remove framework type support Oct 11, 2024
@czy88840616 czy88840616 added pr: polish This PR adds a very minor behavior improvement that users will enjoy. pr: new feature This PR adds a new API or behavior. and removed pr: polish This PR adds a very minor behavior improvement that users will enjoy. labels Oct 11, 2024
@waitingsong
Copy link
Member

waitingsong commented Oct 11, 2024

enum 不能继承扩展这点是很不方便。用 常量对象能扩展,但是类型得额外处理,也麻烦……

@czy88840616
Copy link
Member Author

enum 不能继承扩展这点是很不方便。用 常量对象能扩展,但是类型得额外处理,也麻烦……

对,目前并没有很好的机制去做这个扩展,这里本质上是用在 @App('xx') 的参数中的,现在大多是和组件 namespace 一致的,所以就直接用 namespace就好了。

@czy88840616 czy88840616 merged commit cab5d4f into v4-next Oct 11, 2024
4 checks passed
@czy88840616 czy88840616 deleted the feat/remove_framework_type branch October 11, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. pr: new feature This PR adds a new API or behavior.
Development

Successfully merging this pull request may close these issues.

2 participants