Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): build.gradle namespace #1342

Merged
merged 2 commits into from
Nov 4, 2023
Merged

fix(android): build.gradle namespace #1342

merged 2 commits into from
Nov 4, 2023

Conversation

jonasbadstuebner
Copy link
Contributor

Make it conditional, because it could break the build on Gradle < 8.0

@jonasbadstuebner
fix(android): build.gradle namespace
98515a7 
Make it conditional, because it could break the build on Gradle < 8.0
miguelpruivo
miguelpruivo reviewed Oct 31, 2023
View reviewed changes
Copy link
Owner

@miguelpruivo miguelpruivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been using gradle < 8 without any issues without this. Would you mind to elaborate?

@miguelpruivo miguelpruivo self-assigned this Oct 31, 2023
@navaronbracke
Copy link
Collaborator

This is only an issue for the Android Gradle Plugin < 4.2 iirc

navaronbracke
navaronbracke requested changes Nov 2, 2023
View reviewed changes
android/build.gradle Outdated Show resolved Hide resolved
@miguelpruivo miguelpruivo merged commit 1c21f11 into miguelpruivo:master Nov 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelpruivo miguelpruivo miguelpruivo left review comments

@navaronbracke navaronbracke navaronbracke approved these changes

Assignees

@miguelpruivo miguelpruivo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonasbadstuebner @navaronbracke @miguelpruivo