-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy/paste without escape characters doesn't seem to work anymore #65
Comments
Tested, confirmed (at least on macOS) |
Thanks Martin. Meantime I've confirmed it on Windows and Linux. |
Awesome, thanks for the quick turnaround, much appreciated. |
Any updates on this? Is there already a release available that includes this? |
Thank you, Mihai for the awesome plugin and Martin for fixing. Any good news on release date? |
As a temporal quick-and-dirty solution until the new version of the plugin is released, I replaced the file Tested with Eclipse 2021-06 and 2021-09. Compiled with AdoptOpenJDK-11.0.11+9. Just replace the two jar files inside Eclipse |
Hmm... Strange behavior with this patch. Having some output in the Ansi Console and clicking Ctrl+C on a selected text in any other Eclipse view (e.g. code editor, commit details in history) will copy the whole content of the console (or whatever is selected there) into clipboard. Copying via "Copy" entry from the context menu (as opposed to Ctrl+C shortcut) works properly in other views, but copies with escape characters from Ansi Console. |
My next try is to define a A proper solution from my pov would be intercepting copying operation in the Console (and only there) if the AnsiConsole plugin is activated. |
Released |
Unfortunately, the copying without escape characters (color codes) is not working in Eclipse 2022-09 (where ANSI Console is a default part of Eclipse). In the plugin v1.4.5 and Eclipse 2022-06, it was nicely working. How can we fix that? |
@elab I would recommend to raise this as an enhancement request or bug against https:/eclipse-platform/eclipse.platform.debug |
Explaining why this does not work anymore, and the fact that it was intentional, not an accident When I've integrated this to Eclipse they discovered that some of the things I was doing were not quite OK. They argued (fair enough) that people who install this plugin are people interested in it, and care about its features. But doing something like that in the standard Eclipse, for everybody, goes against the Eclipse UX guidelines. All valid, I am not complaining :-) How to fix it
That hotkey is in fact very old Copy hotkey (still works as Copy in standard OS widgets).
The Enable/Disable and Copy (with/without escapes) are standard Eclipse commands and you can assign whatever hotkeys yoo want.
|
For the default copy behavior discussion during the integration see eclipse-platform/eclipse.platform.debug#57 Reading it again, it was not so much about strictly "don't hijack the standard copy", but mostly a mixture of technical limitations / my lack of knowledge. So I don't want to blame it on others... I expect there will be some fine-tunning for the next few Eclipse versions... |
Looks like the standard copy feature to quickly pull text from the console view excluding the escape sequences (see #19) doesn't work anymore (as someone reported here: spring-projects/sts4#667)
The text was updated successfully, but these errors were encountered: