Omegaconf #116
Merged
Omegaconf #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e latter takes precedence). Also, fixed the slurm part.
plstcharles-mila
approved these changes
Mar 19, 2024
amlrt_project/utils/config_utils.py
Outdated
| :return: | ||
| """ | ||
| parsed_configs = [OmegaConf.load(config) for config in configs] | ||
| merge = OmegaConf.merge(OmegaConf.from_dotlist(cli_config_params), *parsed_configs) |
There was a problem hiding this comment.
Should the "from_dotlist" (argparser) params not override the config params?
For example, if I know my YAML config trains a model for 10 epochs and now I want to train it for 30 (as a side-experiment), I would probably expect my command line modification to override anything in the YAML configs...
There was a problem hiding this comment.
Very good catch. I fixed it now.
plstcharles
approved these changes
Mar 19, 2024
plstcharles
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added omegaconf support, to handle multiple config files in a hierarchical way.
(also added support to pass config file parameters via CLI)