Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: the estimate method when loading the collection #36307

Merged
merged 9 commits into from
Oct 9, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Sep 14, 2024

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 14, 2024
Copy link
Contributor

mergify bot commented Sep 14, 2024

@SimFG Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Sep 14, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added area/compilation size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Sep 20, 2024
Copy link
Contributor

mergify bot commented Sep 20, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Sep 20, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Sep 20, 2024

@SimFG Thanks for your contribution. Please submit with DCO, see the contributing guide https:/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Sep 20, 2024
Copy link
Contributor

mergify bot commented Sep 20, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Sep 20, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Sep 20, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Sep 20, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Sep 20, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG SimFG force-pushed the master branch 3 times, most recently from 5ae3da5 to 36b58b9 Compare September 26, 2024 02:39
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 79.42387% with 50 lines in your changes missing coverage. Please review.

Project coverage is 81.56%. Comparing base (1f47d55) to head (2edb12d).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
internal/querynodev2/segments/segment.go 51.61% 23 Missing and 7 partials ⚠️
internal/core/src/index/IndexFactory.cpp 87.39% 15 Missing ⚠️
internal/core/src/segcore/load_index_c.cpp 76.47% 4 Missing ⚠️
internal/querynodev2/segments/segment_loader.go 97.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36307      +/-   ##
==========================================
+ Coverage   73.29%   81.56%   +8.26%     
==========================================
  Files        1286     1298      +12     
  Lines      152093   153010     +917     
==========================================
+ Hits       111484   124804   +13320     
+ Misses      35575    23136   -12439     
- Partials     5034     5070      +36     
Files with missing lines Coverage Δ
internal/core/src/common/Types.h 18.04% <ø> (-3.91%) ⬇️
internal/core/src/index/IndexFactory.h 100.00% <ø> (ø)
internal/core/src/index/StringIndexMarisa.cpp 64.90% <100.00%> (+64.90%) ⬆️
internal/core/src/segcore/SegmentSealedImpl.cpp 83.67% <ø> (+83.67%) ⬆️
internal/datacoord/compaction_task_clustering.go 78.80% <ø> (-1.20%) ⬇️
internal/datacoord/meta.go 89.80% <ø> (-0.07%) ⬇️
internal/querynodev2/segments/load_index_info.go 26.08% <100.00%> (+2.40%) ⬆️
internal/querynodev2/segments/utils.go 49.67% <ø> (-0.97%) ⬇️
pkg/util/constant.go 100.00% <ø> (ø)
internal/querynodev2/segments/segment_loader.go 76.36% <97.50%> (+0.52%) ⬆️
... and 3 more

... and 340 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Oct 8, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Oct 8, 2024

/run-cpu-e2e

@SimFG
Copy link
Contributor Author

SimFG commented Oct 8, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Oct 8, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaofan-luan
Copy link
Contributor

@SimFG you need to rerun ut

@SimFG
Copy link
Contributor Author

SimFG commented Oct 9, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Oct 9, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Oct 9, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Oct 9, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Oct 9, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Oct 9, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 9, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 9, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@jaime0815
Copy link
Contributor

/lgtm

Copy link
Contributor

mergify bot commented Oct 9, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 130a923 into milvus-io:master Oct 9, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants