Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO labels backgound does not work well with line-spacing 0.4 #147

Closed
merrickluo opened this issue Jul 28, 2023 · 2 comments
Closed

TODO labels backgound does not work well with line-spacing 0.4 #147

merrickluo opened this issue Jul 28, 2023 · 2 comments

Comments

@merrickluo
Copy link

Hi, thanks for the pretty package.

I see the README mentioned it should work fine with line-spacing from 0.1 to 0.4? the font is JetBrains Mono, I'm using doom emacs and disabled org +pretty.

image

@minad
Copy link
Owner

minad commented Jul 28, 2023

Thanks. Obviously 0.4 is too large for your specific combination of fonts. There is not much we can do, except choosing the fonts and tuning the settings more carefully.

One alternative would be to try to use the raise display property as mentioned in #140 to achieve better alignment of TODO/IDEA within the red label box. But then, tuning labels individually based on the font sizes will be complex and costly. In #144 I had a long discussion with the Org maintainer Ihor about the redisplay cost due to org-modern. The more properties we add the more costly org-modern will be for the redisplay engine.

@minad minad closed this as completed Jul 28, 2023
@merrickluo
Copy link
Author

Thanks for the explanation 🙏 , I guess my best option is still patching the font.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants