Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Cloudfront to CloudFront #31

Closed
wants to merge 1 commit into from
Closed

Conversation

5n7-sk
Copy link

@5n7-sk 5n7-sk commented Feb 20, 2020

Fix #30.

@mingrammer
Copy link
Owner

Thank you for correcting it. But, do not edit the node class files by yourself.

Please use the auto-generation script. You can add the cloudfront to TITLE_WORDS map (https:/mingrammer/diagrams/blob/master/config.py#L60) and just run the autogen.sh

Contributing guideline reference: https:/mingrammer/diagrams/blob/master/CONTRIBUTING.md

@gabriel-tessier
Copy link
Collaborator

@mingrammer I gave a try on my fork by just updating the config.py file, I'm a little bite confuse as I was expecting that it will update everywhere but look like it only update the alias do I need to also update the name of the class and the file?
If you can give more details so this long pending issues can be closed.
There's a link in the original issue:
#30
Or directly in my commit on my fork:
gabriel-tessier@b18a909

I'll make a clean PR when it's ok.

m(__)m

@5n7-sk
Copy link
Author

5n7-sk commented May 10, 2020

@gabriel-tessier

Thanks for your contribution.
Also, I'm sorry for putting the pull request on hold.
I've tried it before, but it didn't work as expected like you, so I hope you can fix it instead.

@mingrammer
Copy link
Owner

@gabriel-tessier You should also add the CloudFront to TITLE_WORDS map, then run the autogen.sh to update the node class.

@rickhull
Copy link

rickhull commented May 13, 2020

I believe this PR is now moot, as master branch no longer has any instances of Cloudfront, only CloudFront

@5n7-sk 5n7-sk closed this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo CloudFront
4 participants