Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misaligned Node Labels #7

Closed
bkmeneguello opened this issue Feb 11, 2020 · 14 comments
Closed

Misaligned Node Labels #7

bkmeneguello opened this issue Feb 11, 2020 · 14 comments
Labels
bug Something isn't working

Comments

@bkmeneguello
Copy link

By the way, excellent project!

I've run the examples but the node labels are bad aligned. Maybe I'm using some incompatible graphviz version

  • graphviz: 2.40.1-2
  • diagrams: 0.2.1

clustered_web_services

@mingrammer
Copy link
Owner

Would you please try with graphviz version 2.43.0 (0)?

@isaacanthony
Copy link

I encountered the same bug. The current stable version of graphviz is 2.42.3. Is there a way we could make diagrams' label rendering backwards-compatible with earlier versions of graphviz? I'm using graphviz v2.38.0.

@mingrammer
Copy link
Owner

mingrammer commented Feb 11, 2020

@bkmeneguello @isaacanthony diagrams v0.2.2 is now released. Could you please test with v0.2.2 :)? (changes: increase node height)

@bkmeneguello
Copy link
Author

v0.2.2 still not solved, but improved a little in the right direction ;). I'll try with new graphviz.
clustered_web_services

@isaacanthony
Copy link

isaacanthony commented Feb 11, 2020

I am still seeing the issue as well on graphviz v2.38.0. (On Debian Stretch OS.)

@juanspinelli
Copy link

juanspinelli commented Feb 11, 2020

In windows I have the same problem but now with v0.2.2 the labels look better (before they looked above) https://ibb.co/0yjSh1k

@bkmeneguello
Copy link
Author

The current stable vesion of graphviz is 2.40.1 (https://graphviz.gitlab.io/_pages/Download/Download_source.html) and I'm not able to use a newer version because of missing dependencies. I need to stick to 2.40.1 by now (maybe I can try with docker sooner)

@DylanSp
Copy link

DylanSp commented Feb 11, 2020

Love the project! But I have the same issue with graphviz 2.38, which is what the graphviz install page points to as stable installs for Windows.

@mingrammer
Copy link
Owner

mingrammer commented Feb 11, 2020

I found a root cause (backward compatibility issue). Please waiting for next release!

The imagepos attribute for a node is not backward compatible.

@mingrammer
Copy link
Owner

mingrammer commented Feb 11, 2020

diagrams v0.2.3 is now released. Please check with this version.

cc @bkmeneguello @isaacanthony @juanspinelli @DylanSp

imagepos attribute (for controlling how an image is positioned within its containing node) is available on graphviz >= 2.42.0.

Without imagepos, there will be small white space above node icons. But it is not a big problem I think. Later, when Graphviz 2.42.0 or later is released on Windows and Linux, all the problems will disappear.

@mingrammer mingrammer added the bug Something isn't working label Feb 11, 2020
@juanspinelli
Copy link

Now it looks awesome thanks! https://ibb.co/k011ppr

@DylanSp
Copy link

DylanSp commented Feb 11, 2020

Definitely looks better even with Graphvis 2.38. Thanks for the quick response on this!

@isaacanthony
Copy link

It is fixed. Thanks! Even a little more padding would probably be welcome, but a major improvement. Thank you for your quick response.

@bkmeneguello
Copy link
Author

It's definitely fixed. Thanks a lot. I never saw a fastest maintainer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants