Mirror: Save STag and ETag on destination only in Multimaster or attr…

…ibute preserve mode
minio · Dec 23, 2019 · 7842ad5 · 7842ad5
1 parent ee28381
commit 7842ad5
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/cmd/mirror-main.go b/cmd/mirror-main.go
@@ -303,17 +303,19 @@ func (mj *mirrorJob) doMirror(ctx context.Context, cancelMirror context.CancelFu
  sURLs.TargetContent.Metadata["X-Amz-Storage-Class"] = mj.storageClass
  }
 
- // Set multiMasterETagKey for the target.
- if sURLs.SourceContent.UserMetadata[multiMasterETagKey] != "" {
- sURLs.TargetContent.Metadata[multiMasterETagKey] = sURLs.SourceContent.UserMetadata[multiMasterETagKey]
- } else {
- sURLs.TargetContent.Metadata[multiMasterETagKey] = sURLs.SourceContent.ETag
- }
+ if mj.multiMasterEnable || mj.isPreserve {
+ // Set multiMasterETagKey for the target.
+ if sURLs.SourceContent.UserMetadata[multiMasterETagKey] != "" {
+ sURLs.TargetContent.Metadata[multiMasterETagKey] = sURLs.SourceContent.UserMetadata[multiMasterETagKey]
+ } else {
+ sURLs.TargetContent.Metadata[multiMasterETagKey] = sURLs.SourceContent.ETag
+ }
 
- if sURLs.SourceContent.UserMetadata[multiMasterSTagKey] != "" {
- sURLs.TargetContent.Metadata[multiMasterSTagKey] = sURLs.SourceContent.UserMetadata[multiMasterSTagKey]
- } else {
- sURLs.TargetContent.Metadata[multiMasterSTagKey] = mj.multiMasterSTag
+ if sURLs.SourceContent.UserMetadata[multiMasterSTagKey] != "" {
+ sURLs.TargetContent.Metadata[multiMasterSTagKey] = sURLs.SourceContent.UserMetadata[multiMasterSTagKey]
+ } else {
+ sURLs.TargetContent.Metadata[multiMasterSTagKey] = mj.multiMasterSTag
+ }
  }
 
  if mj.isPreserve {