Accept SECRET_KEY using prompt and standard input. #2785

sinhaashish · 2019-05-31T11:48:20Z

The ACCESS_KEY , SECRET_KEY is taken as an input . This is done to avoid the credentials shown
in ps aux command.
Adding a new user asks for their credentials.

To test:

mc config host add myminio http://192.168.86.149:9000

Enter Access Key : BKIKJAA5BMMU2RHO6IBB
Enter Secret Key : V8f1CwQqAcwo80UEIJEjc5gVQUSSx5ohQ9GSrr12
Added `myminio` successfully.

mc admin user add myminio foobar readonly

Enter Access Key : testuser 
Enter Secret Key : testuser123

Fixes #2651

codecov · 2019-05-31T12:06:18Z

Codecov Report

Merging #2785 into master will decrease coverage by 0.13%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2785      +/-   ##
==========================================
- Coverage    10.5%   10.37%   -0.14%     
==========================================
  Files         129      127       -2     
  Lines       12751    12738      -13     
==========================================
- Hits         1339     1321      -18     
- Misses      11245    11258      +13     
+ Partials      167      159       -8

Impacted Files	Coverage Δ
cmd/config-host-add.go	`0% <0%> (ø)`	⬆️
cmd/admin-user-add.go	`0% <0%> (ø)`	⬆️
cmd/client-fs.go	`27.3% <0%> (-1.72%)`	⬇️
cmd/client-url.go	`66.66% <0%> (-1.45%)`	⬇️
cmd/config.go	`33.33% <0%> (-0.52%)`	⬇️
cmd/fs-pathutils_nix.go
cmd/client-fs_linux.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6756185...54da186. Read the comment docs.

cmd/admin-user-add.go

cmd/config-host-add.go

docs/minio-client-complete-guide.md

cmd/config-host-add.go

cmd/admin-user-add.go

vadmeste

Some comments

cmd/admin-user-add.go

harshavardhana · 2019-06-13T15:53:44Z

Okay so @abperiasamy confirmed two things

preserve the current syntax when all arguments are provided and no change there
show a prompt if user doesn't type all the input options, let's say alias is available and rest are not available throw a prompt. Where each prompt takes accessKey, secretKey etc..

So you need to redo this PR to have this behavior.

sinhaashish · 2019-06-14T00:22:16Z

Okay so @abperiasamy confirmed two things

preserve the current syntax when all arguments are provided and no change there

show a prompt if user doesn't type all the input options, let's say alias is available and rest are not available throw a prompt. Where each prompt takes accessKey, secretKey etc..

So you need to redo this PR to have this behavior.

👍

sinhaashish · 2019-06-26T09:50:02Z

@harshavardhana @vadmeste @poornas modifed the PR. PTAL

cmd/admin-user-add.go

docs/minio-admin-complete-guide.md

cmd/admin-user-add.go

harshavardhana · 2019-06-26T17:47:50Z

One more thing this PR also needs to do is when --json, --quiet or if the tty is not a terminal - it should turn off prompt. This is a script mode or non-interactive.

sinhaashish · 2019-10-08T17:10:04Z

One more thing this PR also needs to do is when --json, --quiet or if the tty is not a terminal - it should turn off prompt. This is a script mode or non-interactive.

Done with the other changes . Can you elaborate if the tty is not a terminal . This PR prompts for access and secret key only if it is not passed. IMO in script mode access and secret key will be passed so it wont prompt for user input.

vadmeste

Some comments

vadmeste · 2019-10-09T14:46:28Z

docs/minio-admin-complete-guide.md

+*Example: Add a new user 'testuser' on MinIO, with 'writeonly' using standard input.*
+
+```sh
+$ set -o history


I think we don't have to disable history if we are entering access & secret keys in the prompt

vadmeste · 2019-10-09T14:47:33Z

cmd/admin-user-add.go

- {{.EnableHistory}}
+ $ set -o history
+ $ {{.HelpName}} myminio foobar foo12345
+ $ set +o history


There is some extra leading spaces here

vadmeste · 2019-10-09T15:58:17Z

docs/minio-client-complete-guide.md

+Enter API signature. An optional argument. Default value 'S3v4' :
+Enter lookup. An optional argument. Default value 'auto' :


I believe both of these prompts are not there

Thanks, removed.

The access and secret key is taken as an input from promt . This is done to avoid the credetials shown in ps aux command. Adding a new user asks for a user credentials.

aead · 2019-10-13T06:46:40Z

cmd/admin-user-add.go

+ value, _, _ := reader.ReadLine()
+ accessKey = string(value)
+ fmt.Printf("%s", console.Colorize(cred, "Enter Secret Key : "))
+ bytePassword, _ := terminal.ReadPassword(int(syscall.Stdin))


Missing proper error handling

Also according to Terminal.ReadPassword we are supposed to pass the prompt. In any case we should use os.File.Fd() instead of the syscall package.

aead · 2019-10-13T06:46:53Z

cmd/admin-user-add.go

+ case numberOfArgs == 2:
+ accessKey = args.Get(1)
+ fmt.Printf("%s", console.Colorize(cred, "Enter Secret Key : "))
+ bytePassword, _ := terminal.ReadPassword(int(syscall.Stdin))


Missing proper error handling

harshavardhana · 2020-01-26T07:20:15Z

are we going to implement this? @kannappanr @sinhaashish - if there are no plans can we close them out?

kannappanr · 2020-01-26T15:25:22Z

ping @sinhaashish

h0tw1r3 · 2020-02-10T08:11:51Z

please implement this. it is not uncommon for security policies to require (or force) shell logging.

@sinhaashish

Based on work by @sinhaashish in minio#2785

@sinhaashish

Based on work by @sinhaashish in minio#2785

@sinhaashish

Based on work by @sinhaashish in minio#2785

@sinhaashish

Based on work by @sinhaashish in minio#2785

sinhaashish · 2020-02-24T09:39:22Z

Closing this for now . Will send another PR for this

harshavardhana · 2020-02-24T13:55:17Z

@sinhaashish would you take a look at #3083

@sinhaashish

Based on work by @sinhaashish in minio#2785

@sinhaashish

Based on work by @sinhaashish in minio#2785

kannappanr requested review from vadmeste and poornas May 31, 2019 18:21

sinhaashish force-pushed the secret-key-prompt branch from 9ca1000 to 3d482f3 Compare June 4, 2019 05:06

poornas requested changes Jun 10, 2019

View reviewed changes

cmd/admin-user-add.go Outdated Show resolved Hide resolved

cmd/config-host-add.go Outdated Show resolved Hide resolved

docs/minio-client-complete-guide.md Outdated Show resolved Hide resolved

cmd/config-host-add.go Outdated Show resolved Hide resolved

harshavardhana requested changes Jun 10, 2019

View reviewed changes

cmd/admin-user-add.go Outdated Show resolved Hide resolved

vadmeste reviewed Jun 10, 2019

View reviewed changes

cmd/admin-user-add.go Outdated Show resolved Hide resolved

cmd/admin-user-add.go Outdated Show resolved Hide resolved

cmd/admin-user-add.go Outdated Show resolved Hide resolved

cmd/admin-user-add.go Outdated Show resolved Hide resolved

sinhaashish force-pushed the secret-key-prompt branch 5 times, most recently from 12bcc47 to 54da186 Compare June 26, 2019 08:05

harshavardhana requested changes Jun 26, 2019

View reviewed changes

cmd/admin-user-add.go Show resolved Hide resolved

cmd/admin-user-add.go Outdated Show resolved Hide resolved

docs/minio-admin-complete-guide.md Outdated Show resolved Hide resolved

aead reviewed Jun 26, 2019

View reviewed changes

cmd/admin-user-add.go Outdated Show resolved Hide resolved

harshavardhana force-pushed the master branch from a359537 to 809741e Compare August 6, 2019 22:46

sinhaashish force-pushed the secret-key-prompt branch from 54da186 to a933298 Compare October 8, 2019 17:02

sinhaashish requested review from harshavardhana, vadmeste, aead and poornas October 9, 2019 03:52

vadmeste reviewed Oct 9, 2019

View reviewed changes

sinhaashish force-pushed the secret-key-prompt branch from a933298 to 6d84281 Compare October 10, 2019 07:23

Accept access, secret key using standard input.

e3b4547

The access and secret key is taken as an input from promt . This is done to avoid the credetials shown in ps aux command. Adding a new user asks for a user credentials.

sinhaashish force-pushed the secret-key-prompt branch from 6d84281 to e3b4547 Compare October 10, 2019 07:28

sinhaashish requested a review from vadmeste October 10, 2019 08:59

aead requested changes Oct 13, 2019

View reviewed changes

h0tw1r3 added a commit to h0tw1r3/mc that referenced this pull request Feb 16, 2020

support keys by standard input

6109656

Based on work by @sinhaashish in minio#2785

h0tw1r3 added a commit to h0tw1r3/mc that referenced this pull request Feb 16, 2020

support keys by standard input

98a414c

Based on work by @sinhaashish in minio#2785

h0tw1r3 added a commit to h0tw1r3/mc that referenced this pull request Feb 16, 2020

support keys by standard input

355423b

Based on work by @sinhaashish in minio#2785

h0tw1r3 added a commit to h0tw1r3/mc that referenced this pull request Feb 16, 2020

support keys by standard input

b6285e7

Based on work by @sinhaashish in minio#2785

h0tw1r3 mentioned this pull request Feb 16, 2020

Secret key prompt #3083

Merged

sinhaashish closed this Feb 24, 2020

h0tw1r3 added a commit to h0tw1r3/mc that referenced this pull request Mar 7, 2020

support keys by standard input

f17ce5c

Based on work by @sinhaashish in minio#2785

h0tw1r3 added a commit to h0tw1r3/mc that referenced this pull request Mar 7, 2020

support keys by standard input

8e754f4

Based on work by @sinhaashish in minio#2785

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Accept SECRET_KEY using prompt and standard input. #2785

Accept SECRET_KEY using prompt and standard input. #2785

sinhaashish commented May 31, 2019 •

edited

Loading

codecov bot commented May 31, 2019 •

edited

Loading

vadmeste left a comment

harshavardhana commented Jun 13, 2019

sinhaashish commented Jun 14, 2019

sinhaashish commented Jun 26, 2019

harshavardhana commented Jun 26, 2019

sinhaashish commented Oct 8, 2019

vadmeste left a comment

vadmeste Oct 9, 2019

sinhaashish Oct 10, 2019

vadmeste Oct 9, 2019

sinhaashish Oct 10, 2019

vadmeste Oct 9, 2019

sinhaashish Oct 10, 2019

aead Oct 13, 2019

aead Oct 13, 2019

aead Oct 13, 2019

harshavardhana commented Jan 26, 2020

kannappanr commented Jan 26, 2020

h0tw1r3 commented Feb 10, 2020

sinhaashish commented Feb 24, 2020

harshavardhana commented Feb 24, 2020

		Enter API signature. An optional argument. Default value 'S3v4' :
		Enter lookup. An optional argument. Default value 'auto' :

Accept SECRET_KEY using prompt and standard input. #2785

Accept SECRET_KEY using prompt and standard input. #2785

Conversation

sinhaashish commented May 31, 2019 • edited Loading

codecov bot commented May 31, 2019 • edited Loading

Codecov Report

vadmeste left a comment

Choose a reason for hiding this comment

harshavardhana commented Jun 13, 2019

sinhaashish commented Jun 14, 2019

sinhaashish commented Jun 26, 2019

harshavardhana commented Jun 26, 2019

sinhaashish commented Oct 8, 2019

vadmeste left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

harshavardhana commented Jan 26, 2020

kannappanr commented Jan 26, 2020

h0tw1r3 commented Feb 10, 2020

sinhaashish commented Feb 24, 2020

harshavardhana commented Feb 24, 2020

sinhaashish commented May 31, 2019 •

edited

Loading

codecov bot commented May 31, 2019 •

edited

Loading