Fix Windows config path #2898

klauspost · 2019-09-18T00:23:52Z

Remove '.exe' (case insensitive) from executable name for consistent config folder.

Potentially breaking: If people (for whatever reason) used 'mc.exe', this will potentially break their setup. No easy fix for that setup, especially since people could have both.

Fixes #2896

Remove '.exe' (case insensitive) from executable name for consistent config folder. Potentially breaking: If people (for whatever reason) used 'mc.exe', this will potentially break their setup.

harshavardhana

We can't change this without supporting existing users, we should ask users to migrate so we should add code to migrate existing users on windows.

harshavardhana · 2019-09-18T00:26:45Z

We should add the migration code in config-migrate.go

// migrate config files from the any older version to the latest.
func migrateConfig() {
        // Migrate config V1 to V101
        migrateConfigV1ToV101()
        // Migrate config V101 to V2
        migrateConfigV101ToV2()
        // Migrate config V2 to V3
        migrateConfigV2ToV3()
        // Migrate config V3 to V4
        migrateConfigV3ToV4()
        // Migrate config V4 to V5
        migrateConfigV4ToV5()
        // Migrate config V5 to V6
        migrateConfigV5ToV6()
        // Migrate config V6 to V7
        migrateConfigV6ToV7()
        // Migrate config V7 to V8
        migrateConfigV7ToV8()
        // Migrate config V8 to V9
        migrateConfigV8ToV9()
        // Migrate config location on windows
        fixConfigLocation()
}

klauspost · 2019-09-18T00:28:13Z

Yeah. I guess we can overwrite it with the current invocation type. Lemme see what I can cook up.

klauspost · 2019-09-26T21:02:23Z

Tests. You can track directories by their timestamp.

λ go build && dir c:\users\klaus\mc* && mc config host list && dir c:\users\klaus\mc*
 Directory of c:\users\klaus                                                         
                                                                                     
05/09/2019  18.17    <DIR>          mc                                               
26/09/2019  13.46    <DIR>          mc.exe                                           
               0 File(s)              0 bytes                                        
               2 Dir(s)  201.392.041.984 bytes free                                  
[....]                                                                                     
 Directory of c:\users\klaus                                                         
                                                                                     
05/09/2019  18.17    <DIR>          mc                                               
26/09/2019  13.46    <DIR>          mc.unused                                        
               0 File(s)              0 bytes                                        
               2 Dir(s)  201.392.041.984 bytes free

Called without .exe, config renamed mc.exe -> mc.unused. Calling again does nothing.

Calling with .exe and no .exe folder, nothing happens:

c:\gopath\src\github.com\minio\mc (fix-windows-config-path -> origin)                   
λ go build && dir c:\users\klaus\mc* && mc.exe config host list && dir c:\users\klaus\mc
 Directory of c:\users\klaus                                                            
                                                                                        
05/09/2019  18.17    <DIR>          mc                                                  
26/09/2019  13.46    <DIR>          mc.unused                                           
               0 File(s)              0 bytes                                           
               2 Dir(s)  201.391.525.888 bytes free                                     
[....]
 Directory of c:\users\klaus                                                            
                                                                                        
05/09/2019  18.17    <DIR>          mc                                                  
26/09/2019  13.46    <DIR>          mc.unused                                           
               0 File(s)              0 bytes                                           
               2 Dir(s)  201.391.525.888 bytes free

Calling with .exe will move the bare mc folder to mc.unused and move mc.exe to mc:

λ go build && dir c:\users\klaus\mc* && mc.exe config host list && dir c:\users\klaus\mc*
 Directory of c:\users\klaus                                                             
                                                                                         
05/09/2019  18.17    <DIR>          mc                                                   
26/09/2019  13.46    <DIR>          mc.exe                                               
               0 File(s)              0 bytes                                            
               2 Dir(s)  201.445.535.744 bytes free                                      
[...]                                                                                         
 Volume in drive C is OS                                                                 
 Volume Serial Number is 5C65-5220                                                       
                                                                                         
 Directory of c:\users\klaus                                                             
                                                                                         
26/09/2019  13.46    <DIR>          mc                                                   
05/09/2019  18.17    <DIR>          mc.unused                                            
               0 File(s)              0 bytes                                            
               2 Dir(s)  201.445.535.744 bytes free

Finally, if called with .exe and there is no folder without extension it is simply renamed mc.exe -> mc:

λ go build && dir c:\users\klaus\mc* && mc.exe config host list && dir c:\users\klaus\mc* 
 Directory of c:\users\klaus                                                              
                                                                                          
26/09/2019  13.46    <DIR>          mc.exe                                                
05/09/2019  18.17    <DIR>          mc.unused                                             
               0 File(s)              0 bytes                                             
               2 Dir(s)  201.447.510.016 bytes free                                       
[....]
 Directory of c:\users\klaus                                                              
                                                                                          
26/09/2019  13.46    <DIR>          mc                                                    
05/09/2019  18.17    <DIR>          mc.unused                                             
               0 File(s)              0 bytes                                             
               2 Dir(s)  201.447.510.016 bytes free

klauspost · 2019-09-26T21:11:54Z

@harshavardhana Updated with config location migration. 😅💦

I rename the unused config instead of just deleting it.

kannappanr · 2019-10-08T21:29:01Z

ping @harshavardhana @vadmeste

vadmeste

LGTM

kannappanr · 2019-10-10T22:54:57Z

@klaus PTAL Github action failures.

harshavardhana · 2019-10-10T22:58:42Z

@klaus PTAL Github action failures.

The issue was related to GitHub server-side bug.

klauspost · 2019-10-11T09:02:57Z

@harshavardhana Fixed. It seems to have dismissed the reviews automatically.

vadmeste

LGTM

audunmg · 2020-01-03T15:15:23Z

When the executable is in the user's home folder (c:\users\audunmg\mc.exe) this renames the executable mc.exe to mc.unused or mc, and fails.

* Fix zh_CN doc about policy errors (minio#2927) * Fix Windows config path (minio#2898) Remove '.exe' (case insensitive) from executable name for consistent config folder. Potentially breaking: If people (for whatever reason) used 'mc.exe', this will potentially break their setup. * Fix removing empty prefixes with `mc rm ` command (minio#2912) Fixes: 2909 * Add --type flag to `mc admin console` (minio#2914) This allows filtering error logs by type * Update mc to use secure-io package (minio#2931) * Refactor mc cp and make session optional. (minio#2910) Now `mc cp --recursive --continue` creates copy session on failure or resumes if previous failed session is found. Fixes minio#2893 * continue flag: Fix inconsistent punctuation in usage text (minio#2933) * fix mc cp termination on signals (minio#2934) * Adapt new changes in StorageInfo (minio#2889) * Fix arrow signs to use more common U+2191 & U+2193 (minio#2942) * Avoid index out of range errors (minio#2943) Fixes minio#2941 * Fix typo in error message (minio#2945) Change the error message from `Cannot remove new user` to `Cannot remove <User>`, when a non-existent user is removed. * Add options to preserve filesystem attributes (minio#2938) * mc admin config set/get/del/history/help (minio#2835) Related to minio/minio#8392 * print disk usage as a plain integer when formatting as json (minio#2946) * Fix the storage prints for xl/fs disks in `admin info server` (minio#2947) * Fix config history to list in git style format (minio#2951) ``` ~ mc admin config history list -n 2 myminio RestoreId: df0ebb1e-69b0-4043-b9dd-ab54508f2897 Date: Mon, 04 Nov 2019 17:27:27 GMT region name="us-east-1" state="on" region name="us-east-1" state="on" region name="us-east-1" state="on" region name="us-east-1" state="on" RestoreId: ecc6873a-0ed3-41f9-b03e-a2a1bab48b5f Date: Mon, 04 Nov 2019 17:28:23 GMT region name=us-east-1 state=off ``` * add lock command (minio#2880) `lock` command enables to set, get and clear object lock configuration of given bucket. * update to latest minio (minio#2956) * Fix encrypt-key flag parsing (minio#2955) * update to latest minio (minio#2957) * Rectify usage section of policy help (minio#2959) * help command is now part of `mc admin config get/set` (minio#2961) * mirror object lock configuration to dest bucket (minio#2964) if bucket does not exist on the target side. * Add default values in 'get' (minio#2962) * Add mirror command to compare metadata and copy (minio#2965) mirror now uses the newly introduced ListObjectsV2WithMetadata API in minio-go * Handle PutObjectRetention notification events correctly (minio#2966) * Retention command to apply retention to objects with a Prefix (minio#2963) * Fix totalSize and totalCounts calculation (minio#2969) * Add import/export command (minio#2974) * Add support for auto-complete in 'mc admin config' commands (minio#2975) * Remove duplicated API method(s) for object retention (minio#2973) * Fix progress bar update regression (minio#2976) Regression introduced in cf6defe * Update export command to print disabled sub-sys as comments (minio#2978) * Add finalized command line options (minio#2979) * Avoid re-parsing config history elements (minio#2981) * change target to name in config help (minio#2983) * fix: Source content can be nil when updating progress bar (minio#2984) * Continue mirroring inspite of error events (minio#2986) * watch: Add site wide level support (minio#2987) * Continue listing upon error during diff and mirror (minio#2988) * Support for multi master sites (minio#2991) * Retry mirror forever on watch (minio#2992) * Fix multi-master setup help text (minio#2993) * Do full scan diff+mirror in multi-site mirror mode (minio#2994) * update minio-go to master (minio#2995) * Avoid mirror fatalIf in multi-master (minio#2998) * Mirror with fallback list in multimaster mode, copy missing files (minio#2999) * Fix mirroring of PutObjectRetention event (minio#3004) * Multi-master only run single startMirror at a time (minio#3003) Also randomize the sleep appropriately based on Unix() time source. * mc sql: Use compression parameter (minio#2996) The compression parameter is not actually used, but always guessed from the file extension. Only guess the compression type if it is not explicitly set. Uploading a file called `out.csv.geezipd`: Before: ``` λ mc sql -e="SELECT * from s3object LIMIT 1" --compression=GZIP --csv-input "rd=\n,fh=USE,fd=;" local/test/out.csv.geezipd �""��k↔��Xs��W.v� ��)��{2#��,r��:�|D▲�.��f♫��→�i�p�2l�♫��ʭ��Q��v▲�5ر�c ``` (content actually not ungzipped) After: ``` λ mc sql -e="SELECT * from s3object LIMIT 1" --compression=GZIP --csv-input "rd=\n,fh=USE,fd=;" local/test/out.csv.geezipd "281,1285,159625,159627,2637,20000827.0117590018,1239029,1663,-6.7535419,1533,0.53597438,8" ``` We leave validation of the compression value to the server. * Replace Timestamp separator (minio#3002) Replace time stamp separator to use `-` * New admin info (minio#2982) * Stops showing usage info if Bucket#=0 (minio#3007) * Extraneous line in 'mc admin info' output (minio#3010) * cp: Only use session when -c is passed (minio#2989) * Upgrade to new Listen bucket API (minio#3008) * fix: ignore APINotImplemented errors from filesystem (minio#3018) * Update to latest minio/minio (minio#3020) * Mirror: Generate STag and ETag on destination only in Multimaster mode (minio#3021) * Update mc dependencies to recent dep change on MinIO (minio#3026) * Use colorjson to indent json properly in cp (minio#3030) Additionally also do not initialize progress bar in json or quiet mode in mirror. Fixes minio#3029 Fixes minio#3017 * fix default flag behaviour in du command (minio#3031) - `mc du` without args should print help like other `mc` commands - `mc du` should behave like `du -h --max-depth=1` as default - optional `--recursive` if they want capacity for each folder. fixes minio#2871 * Add lock and retention docs (minio#3034) * Only rename config directories (minio#3032) If the user placed an `mc.exe` in the user directory and wasn't used it, it would be renamed. * fix: crash in cp when cpURLs return error (minio#3035) * fix: du to ignore too many recursive symlinks (minio#3033) * fix: update docs for --attr command (minio#3040) Also canonicalize metadata headers automatically before, minio-go consumes it. * retention: Error out early when url argument does not point to S3 server (minio#3041) * fix: update minio-go to support snowball data-transfer (minio#3042) * cp: add missing } in help template (minio#3047) * Update pkg/madmin to support multiple profilers (minio#3048) * admin/console: Fix a crash in console string generation (minio#3049) * fix: best effort save permissions always (minio#3050) * upgrade to latest server to remove replace tags (minio#3051) * fix: update admin docs for latest changes (minio#3054) * fix: handle symlinks by reading/following as needed (minio#3053) Avoid using filepath.EvalSymlinks and let the caller fail appropriately for symlinks. Fixes minio#3011 * check for bucket exists in 'admin heal' (minio#3059) * Ensure 64bit alignment on 32bit builds for atomics (minio#3065) Keep elements that are used with atomic.* functions as first element of struct because it guarantees 64bit alignment on 32 bit machines. atomic.* functions crash if operand is not aligned at 64bit. See golang/go#599 * add the `mc admin kms` subcommands (minio#2882) This commit adds the first set of KMS admin commands. For new there is only the `mc admin kms key status <endpoint> [key-ID]` command that can be used to fetch status information for a KMS master key. Listing and rotation commands are planed. * Fix go.sum file missing entries (minio#3071) * add debug support for 'config host add' (minio#3076) * Fix crash in mc admin console (minio#3079) Fixes : minio#3078 * use latest minio-go version (minio#3080) * allow mirror to copy zero byte file (minio#3084) this PR also cleans up code and avoids extra calls for source target * go mod tidy (minio#3081) * honor prefix for object and directory names in 'rm -r' (minio#3012) * fix go mod tidy again * added pkg/disk/stat_freebsd.go (minio#3090) * fix handling of directories in Stat (minio#3092) Fixes minio#3089 Fixes minio#3091 * retention - cleanup unused code (minio#3094) * Use listObjectsV1 for GCS S3 implementation (minio#3101) Fixes minio#3073 * Support arm32, 386 compilation: (minio#3103) * deprecate 'mc session' documentation (minio#3104) * Add support of threads & goroutines profiling type (minio#3108) * fix go mod tidy * Update minio-go to bring some fixes (minio#3106) * resolve build issues on illumos (minio#3098) * Update docs for mc admin update (minio#3110) * fix: Make sure Ctrl-C cancels `mc cp` right away (minio#3113) * mc cp -continue: Fix escape/colorization of JSON (minio#3116) * info: Fix showing offline nodes in the pretty output (minio#3112) Also do some simplification in the code. * Secret key prompt (minio#3083) * heal: Show scheduled next healing (minio#3111) mc admin heal alias command will show the next healing time. Also, show 'Never completed' when the server returns zero last healing activity * mc cp: Fix prefix handling in TypeC (minio#3115) for copy from filesystem to objectstorage. Avoid prefixing dirname to file on target side when doing a `mc cp /tmp/dir myminio/bucket --r` to make `mc mirror` and `mc cp` behavior consistent * info: Add missing new lines in the output (minio#3119) * fix for incorrect mtime handling (minio#3121) * mc retention: add --recursive and --bypass flags. (minio#3100) --bypass flag allows overriding governance if user has override permissions * cleanup legacy metadata handling (minio#3118) * Add global context and adapt context change in admin API (minio#3125) This commit adds a new global context, monitors os signals and cancels the global context in such cases to exit on going process gracefully. It will also update minio-go and adapts the code with the new context changes in the admin API. * Add tag command (minio#3117) * cleanup tag command (minio#3126) * Add legalhold command (minio#3095) * mc watch windows URL/absolute path event path (minio#3133) * Onboard Diagnostics (minio#3114) Also colorize JSON output in all admin commands * Make BuildS3Config public (minio#3132) * add build trimpaths to remove gopath (minio#3137) * add --disable-multipart flag in cp (minio#3135) * set S3Client struct as public * set s3client struct as public to be used by mcs Co-authored-by: yiranzai <[email protected]> Co-authored-by: Klaus Post <[email protected]> Co-authored-by: poornas <[email protected]> Co-authored-by: Harshavardhana <[email protected]> Co-authored-by: Bala FA <[email protected]> Co-authored-by: Ashish Kumar Sinha <[email protected]> Co-authored-by: Praveen raj Mani <[email protected]> Co-authored-by: Nitish Tiwari <[email protected]> Co-authored-by: kannappanr <[email protected]> Co-authored-by: Wesley Collin Wright <[email protected]> Co-authored-by: Krishna Srinivas <[email protected]> Co-authored-by: Anis Elleuch <[email protected]> Co-authored-by: BigUstad <[email protected]> Co-authored-by: ebozduman <[email protected]> Co-authored-by: Maël Valais <[email protected]> Co-authored-by: Reinhard Koehn <[email protected]> Co-authored-by: Andreas Auernhammer <[email protected]> Co-authored-by: Dmitry Wagin <[email protected]> Co-authored-by: Kody A Kantor <[email protected]> Co-authored-by: Jeffrey Clark <[email protected]> Co-authored-by: Sidhartha Mani <[email protected]> Co-authored-by: Daniel Valdivia <[email protected]>

Fix Windows config path

42a0e78

Remove '.exe' (case insensitive) from executable name for consistent config folder. Potentially breaking: If people (for whatever reason) used 'mc.exe', this will potentially break their setup.

harshavardhana requested changes Sep 18, 2019

View reviewed changes

kannappanr requested a review from vadmeste September 18, 2019 01:02

Add Windows config location migration.

bb092e1

harshavardhana previously approved these changes Sep 26, 2019

View reviewed changes

Move config files as the first migration.

51efe1a

klauspost dismissed harshavardhana’s stale review via 51efe1a September 26, 2019 22:56

harshavardhana previously approved these changes Oct 8, 2019

View reviewed changes

vadmeste previously approved these changes Oct 9, 2019

View reviewed changes

Merge branch 'master' into fix-windows-config-path

42a7d10

Merge branch 'master' into fix-windows-config-path

19343d8

Remove extra newline.

bc9e5a7

klauspost dismissed stale reviews from vadmeste and harshavardhana via bc9e5a7 October 11, 2019 08:10

vadmeste approved these changes Oct 11, 2019

View reviewed changes

harshavardhana approved these changes Oct 11, 2019

View reviewed changes

kannappanr merged commit aa4a477 into minio:master Oct 11, 2019

klauspost deleted the fix-windows-config-path branch October 12, 2019 12:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Windows config path #2898

Fix Windows config path #2898

klauspost commented Sep 18, 2019

harshavardhana left a comment

harshavardhana commented Sep 18, 2019

klauspost commented Sep 18, 2019

klauspost commented Sep 26, 2019

klauspost commented Sep 26, 2019

kannappanr commented Oct 8, 2019

vadmeste left a comment

kannappanr commented Oct 10, 2019

harshavardhana commented Oct 10, 2019

klauspost commented Oct 11, 2019

vadmeste left a comment

audunmg commented Jan 3, 2020

Fix Windows config path #2898

Fix Windows config path #2898

Conversation

klauspost commented Sep 18, 2019

harshavardhana left a comment

Choose a reason for hiding this comment

harshavardhana commented Sep 18, 2019

klauspost commented Sep 18, 2019

klauspost commented Sep 26, 2019

klauspost commented Sep 26, 2019

kannappanr commented Oct 8, 2019

vadmeste left a comment

Choose a reason for hiding this comment

kannappanr commented Oct 10, 2019

harshavardhana commented Oct 10, 2019

klauspost commented Oct 11, 2019

vadmeste left a comment

Choose a reason for hiding this comment

audunmg commented Jan 3, 2020