Add tags including lang and hreflang attrs for all docs #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of adding new fields to the yml file, we check the output directory to determine if the page is for English or Chinese docs.
This commit checks if the link is valid for the translation of the page before adding the link tags with relevant hreflang attributes.
kaankabalak
changed the title
|
@kanagarajkm we decided to do a much more simpler way of doing lang tags. Will discuss with AB and merge accordingly |
|
@kaankabalak I had a discussion with @abperiasamy We are changing how we implement this. Marking this invalid since it's no longer applicable. But thank you for the pr. It helped a great deal while having the discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes done specifically for the miniohq/gluegun
fork, compared to a more general approach where extra fields were
added to the yml file.