Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNCP check all #546

Merged
merged 1 commit into from
Mar 2, 2022
Merged

RNCP check all #546

merged 1 commit into from
Mar 2, 2022

Conversation

ericplaquevent
Copy link
Contributor

@ericplaquevent ericplaquevent commented Feb 28, 2022

Check RNCP data for France Competence study. Metabase dashboard will follow.
https://trello.com/c/BszZOLOw/952-rncp-check-des-sirets-habilités-partout-pour-analyse-dimpact-pas-de-mise-en-prod-à-ce-stade

Bonus: TypeScript errors for js files with // @ts-check comment. https://code.visualstudio.com/docs/languages/jsconfig#_why-do-i-need-a-jsconfigjson-file

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2022

Codecov Report

Merging #546 (441a45a) into develop (336271c) will increase coverage by 0.09%.
The diff coverage is 94.44%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #546      +/-   ##
===========================================
+ Coverage    49.27%   49.36%   +0.09%     
===========================================
  Files          266      266              
  Lines         6109     6120      +11     
  Branches      1125     1125              
===========================================
+ Hits          3010     3021      +11     
  Misses        2974     2974              
  Partials       125      125              
Impacted Files Coverage Δ
...ver/src/common/model/schema/formation/formation.js 90.00% <ø> (ø)
server/src/logic/mappers/etablissementsMapper.js 98.80% <94.44%> (-1.20%) ⬇️
server/src/common/esClient/mongoosastic/index.js 57.72% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 336271c...441a45a. Read the comment docs.

@ericplaquevent ericplaquevent force-pushed the feature/rncp-check-all branch 4 times, most recently from 7ad577c to 18f1b0c Compare March 2, 2022 11:14
@ericplaquevent ericplaquevent marked this pull request as ready for review March 2, 2022 12:58
@ericplaquevent ericplaquevent merged commit 439a32c into develop Mar 2, 2022
@ericplaquevent ericplaquevent deleted the feature/rncp-check-all branch March 2, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants