Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): botWarnとdevTickerを統一 #14455

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Aug 22, 2024

What

Why

Fix #14447

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Aug 22, 2024
@syuilo
Copy link
Member

syuilo commented Aug 22, 2024

botWarnを左上にするとかで良いんじゃないかしら

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 19.47%. Comparing base (2aebdb8) to head (a77aef9).

Files with missing lines Patch % Lines
packages/frontend/src/ui/_common_/common.vue 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14455       +/-   ##
============================================
- Coverage    39.72%   19.47%   -20.26%     
============================================
  Files         1541      714      -827     
  Lines       192305   100739    -91566     
  Branches      2470      986     -1484     
============================================
- Hits         76394    19616    -56778     
+ Misses      115349    80578    -34771     
+ Partials       562      545       -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih changed the title fix(frontend): 二段階認証の設定ダイアログはbotWarnよりも上に表示するように fix(frontend): botWarnとdevTickerを統一 Aug 22, 2024
@kakkokari-gtyih
Copy link
Contributor Author

image

@kakkokari-gtyih
Copy link
Contributor Author

👀

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

👀

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消👀

@kakkokari-gtyih kakkokari-gtyih added this to the v2024.9.0 milestone Sep 19, 2024
@acid-chicken
Copy link
Member

botWarn が devTicker っぽくなるのは嬉しくない #9386

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Sep 19, 2024

botWarn が devTicker っぽくなるのは嬉しくない #9386

とはいえ画面真ん中だと実影響が出ている(元issue参照)ので今のアプローチじゃなくてもどうにかしたい

@kakkokari-gtyih kakkokari-gtyih removed this from the v2024.9.0 milestone Sep 21, 2024
@syuilo
Copy link
Member

syuilo commented Sep 23, 2024

botを一時的に解除してもらうので良い気もする(もしくはbot設定する前に2fa設定を終わらせてもらうか)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Botアカウントだと警告表示が邪魔で2FAのQRが読み込めない
3 participants