-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(backend): Defer instance metadata update #14558
Conversation
このPRによるapi.jsonの差分 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14558 +/- ##
===========================================
+ Coverage 39.53% 39.57% +0.03%
===========================================
Files 1543 1544 +1
Lines 193142 193240 +98
Branches 3489 2489 -1000
===========================================
+ Hits 76364 76467 +103
+ Misses 116213 116208 -5
Partials 565 565 ☔ View full report in Codecov by Sentry. |
あ〜〜 5分後に UPDATE 発行されることになってるからテスト用テーブルが解体されたあとにクエリが飛んでテストがエラーになっとる…… |
MisskeyIO#735 もこっちに入れたほうが良かったりします? |
引き継ぎます |
@syuilo 動けてなくて申し訳ないです。よろしくお願いします。 |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
🙏🏻 |
* Defer instance metadata update * Fix last new line * Fix typo * Add license notice * Fix syntax * Perform deferred jobs on shutdown * Fix missing async/await * Fix typo :) * Update collapsed-queue.ts --------- Co-authored-by: syuilo <[email protected]>
* fix(backend/test): MisskeyIO#727 以降e2eテストがたまに失敗する問題を修正 (MisskeyIO#735) * ✌️ --------- Co-authored-by: まっちゃとーにゅ <[email protected]>
What
#11093 の対応を、Redis などを使わずにお手軽に in-process でやるパッチです。
Why
inbox に同一ホストからの note がたくさん入ってくると
UPDATE instance
が行ロックを取り合って渋滞するので、更新をメモリ上で潰して数を減らすことでそれを解決します。Additional info (optional)
@syuilo 1案として書いてみたので参考にしてください。
Checklist