fix(frontend): ユーザー・ノート検索の確定挙動をformタグ経由で行うように #14572
Open
+20
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
うーーーーむ |
|
formに頼るのは無理が生じてきそう(formは古典的な文書寄りのHTML向けの設計だけど、Misskey WebはWebアプリ寄りのため) |
|
実際このPRでもボタンとは言い難いものをbuttonにしなければいけなくなっているし |
|
あと使えるタグに制限が生じそうな気もする |
|
そこら辺はformタグの仕様を調べたりする必要があるけど、めんどくさいから大人しくdiv使っといてJSで制御した方が良さそう |
MkFoldableSectionのボタンの場所を変えたのはどっちかというとフォーカスの当たり方の調整 |
スマホのキーボードの確定ボタンに対応するイベントあるのかしら |
|
enterイベントだわね |
元issueによるとそれが動作しないとのことなのでこういうアプローチにしたんだけど… |
|
謎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
type=buttonを指定しないとsubmitのボタンとして扱われるのでそのへんの改変も含んでいるWhy
Fix #14570
Additional info (optional)
Checklist