Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(embed): improve embed performance #14613

Merged
merged 7 commits into from
Sep 23, 2024
Merged

perf(embed): improve embed performance #14613

merged 7 commits into from
Sep 23, 2024

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Sep 23, 2024

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Sep 23, 2024
@syuilo
Copy link
Member Author

syuilo commented Sep 23, 2024

なんかコンポーネントがレンダリングされない :angry_ai:

Copy link
Contributor

github-actions bot commented Sep 23, 2024

api.jsonの差分作成中にエラーが発生しました。詳細はWorkflowのログを確認してください。

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 66 lines in your changes missing coverage. Please review.

Project coverage is 39.71%. Comparing base (2aebdb8) to head (3197783).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ages/backend/src/server/web/ClientServerService.ts 0.00% 66 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14613      +/-   ##
===========================================
- Coverage    39.72%   39.71%   -0.02%     
===========================================
  Files         1541     1541              
  Lines       192305   192371      +66     
  Branches      2470     3530    +1060     
===========================================
+ Hits         76394    76399       +5     
- Misses      115349   115378      +29     
- Partials       562      594      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member Author

syuilo commented Sep 23, 2024

TASUKETE

@kakkokari-gtyih
Copy link
Contributor

yaruka

@kakkokari-gtyih
Copy link
Contributor

具体的に何をやろうとしてる?

@syuilo
Copy link
Member Author

syuilo commented Sep 23, 2024

APIリクエスト減らした

@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Sep 23, 2024

APIリクエスト減らした

TASUKETE

何に困ってたの?

@syuilo
Copy link
Member Author

syuilo commented Sep 23, 2024

これ
#14613 (comment)

@kakkokari-gtyih
Copy link
Contributor

良い感じになったかもしれない(MK_DEV_PREFER=backendで問題なく動作した。Vite HMRは今検証中)

@kakkokari-gtyih
Copy link
Contributor

いけてそう

@syuilo syuilo marked this pull request as ready for review September 23, 2024 10:49
@syuilo syuilo merged commit 3f0aaaa into develop Sep 23, 2024
30 checks passed
@syuilo syuilo deleted the embed-perf branch September 23, 2024 10:49
@syuilo
Copy link
Member Author

syuilo commented Sep 23, 2024

🙏🏻 🙏🏻 🙏🏻

kakkokari-gtyih added a commit to kakkokari-gtyih/misskey that referenced this pull request Sep 24, 2024
HotoRas pushed a commit to HotoRas/misskey-neko that referenced this pull request Sep 27, 2024
* wip

* wip

* wip

* refactor

* refactor

---------

Co-authored-by: かっこかり <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants