Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リリースPRのレビューの修正 (#14675) #14705

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

#14675 (review) の修正

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels Oct 5, 2024
@kakkokari-gtyih kakkokari-gtyih marked this pull request as draft October 5, 2024 04:33
@kakkokari-gtyih
Copy link
Contributor Author

コミットメッセージがまずい可能性があるのでdraft

@kakkokari-gtyih kakkokari-gtyih changed the title fix: #14675 レビューの修正 #14675 レビューの修正 Oct 5, 2024
Copy link
Contributor

github-actions bot commented Oct 5, 2024

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@kakkokari-gtyih kakkokari-gtyih changed the title #14675 レビューの修正 リリースPRのレビューの修正 (#14675) Oct 5, 2024
@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review October 5, 2024 04:35
@kakkokari-gtyih
Copy link
Contributor Author

コミットメッセージがまずい可能性があるのでdraft

解消した

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.82%. Comparing base (8869846) to head (1ce898a).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ackages/backend/src/server/api/ApiServerService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14705       +/-   ##
============================================
+ Coverage    39.57%   61.82%   +22.24%     
============================================
  Files         1548      829      -719     
  Lines       194523    92439   -102084     
  Branches      3600     2609      -991     
============================================
- Hits         76982    57149    -19833     
+ Misses      116973    35271    -81702     
+ Partials       568       19      -549     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit d8bf1ff into misskey-dev:develop Oct 5, 2024
33 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 5, 2024

👍🏿

@kakkokari-gtyih kakkokari-gtyih deleted the fix-14675-0 branch October 5, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants