Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): クライアント上での時間ベースの実績獲得動作が実績獲得後も発動している問題を修正 #14717

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Oct 7, 2024

What

実績獲得用のsetIntervalとかsetTimeoutが実績解除後は動かないように

Why

実績解除後は特に意味をなさない動作のため回避してパフォーマンス改善したい

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

GeopJr and others added 2 commits October 7, 2024 08:57
…m in main-boot

(cherry picked from commit c0702fd92f70782005517c0065048ececa1ef287)
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 19.59%. Comparing base (0d7d109) to head (b033d4e).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/boot/main-boot.ts 0.00% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14717       +/-   ##
============================================
- Coverage    41.29%   19.59%   -21.71%     
============================================
  Files         1553      719      -834     
  Lines       200329   102161    -98168     
  Branches      3624      988     -2636     
============================================
- Hits         82735    20021    -62714     
+ Misses      117026    81593    -35433     
+ Partials       568      547       -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit d2f1d45 into misskey-dev:develop Oct 7, 2024
23 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 7, 2024

🙏🏿

@kakkokari-gtyih kakkokari-gtyih deleted the fix-interval-achievements-run-when-not-claimed branch October 7, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants