enhance: introduce testCaptcha #14745
Open
+130
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/frontend
|
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -90,6 +90,9 @@
"null"
]
},
+ "enableTestcaptcha": {
+ "type": "boolean"
+ },
"swPublickey": {
"type": [
"string",
@@ -582,6 +585,7 @@
"recaptchaSiteKey",
"enableTurnstile",
"turnstileSiteKey",
+ "enableTestcaptcha",
"swPublickey",
"mascotImageUrl",
"bannerUrl",
@@ -13961,6 +13965,9 @@
"null"
]
},
+ "enableTestcaptcha": {
+ "type": "boolean"
+ },
"sensitiveMediaDetection": {
"type": "string",
"enum": [
@@ -81952,6 +81959,9 @@
"null"
]
},
+ "enableTestcaptcha": {
+ "type": "boolean"
+ },
"swPublickey": {
"type": [
"string",
@@ -82136,6 +82146,7 @@
"recaptchaSiteKey",
"enableTurnstile",
"turnstileSiteKey",
+ "enableTestcaptcha",
"swPublickey",
"mascotImageUrl",
"bannerUrl", |
|
レビュワーを募集しております |
anatawa12
reviewed
Oct 10, 2024
There was a problem hiding this comment.
このコンポーネントはCaptchaの抽象層だと思うのでTestCaptchaの実装は別コンポーネントにしたいきがするけどいい切り分け単位も思いつかない
| @@ -113,6 +119,7 @@ function resetCaptcha() { | |||
| mCaptcha.value?.reset(); | |||
| reCaptcha.value?.reset(); | |||
| turnstile.value?.reset(); | |||
| testcaptcha.value?.reset(); | |||
There was a problem hiding this comment.
testcaptcha.value?.reset がundefinedになる可能性あると思うけどここでは?.()になってないのが気になった。
packages/frontend/src/components/MkSignupDialog.form.vue では reset?.()となってる
anatawa12
reviewed
Oct 10, 2024
| @@ -29,7 +40,7 @@ export type Captcha = { | |||
| getResponse(id: string): string; | |||
| }; | |||
There was a problem hiding this comment.
元をたどるとCaptcha.resetメソッドがoptionalと定義されてないのが悪そうかも
There was a problem hiding this comment.
vueのexposeのほうのresetを発火しているはずなので、外部から参照されるresetがundefinedになる心配はなさそう
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolve #14740
Why
Additional info (optional)
無理やりsubmitしてもサーバーサイドのtestCaptchaの検証で弾かれてエラーになる
Checklist