Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: Stop getting all grades when calling enter_grades (and possibly other places too) #111

Open
pdpinch opened this issue Aug 24, 2015 · 1 comment
Open

Performance: Stop getting all grades when calling enter_grades (and possibly other places too) #111

pdpinch opened this issue Aug 24, 2015 · 1 comment
Assignees
@giocalitri
Labels
P1

Comments

@pdpinch
Copy link
Member

pdpinch commented Aug 24, 2015

As course staff, I would like the grading submissions interface for SGA to be as performant as possible. In particular, I don't need to request an update of all the grades in the course every time I enter a new grade (or delete a grade, or... )

From #100

It looks like enter_grade has some potential optimizations, in particular removing the updating of all grades when we could just update the one that the user changed. This pattern appears in a few places.
@pdpinch pdpinch added the P1 label Aug 24, 2015
@pdpinch pdpinch mentioned this issue Aug 24, 2015
Open
@pdpinch pdpinch assigned giocalitri and unassigned ShawnMilo Aug 24, 2015
@pdpinch pdpinch changed the title Stop pulling all grades when calling enter_grades (and possibly other places too) Performance: Stop getting all grades when calling enter_grades (and possibly other places too) Aug 24, 2015
@pdpinch pdpinch added this to the 8/29 Sprint milestone Aug 24, 2015
@pdpinch pdpinch closed this as completed in 2a37338 Sep 4, 2015
pdpinch added a commit that referenced this issue Sep 4, 2015
@pdpinch
Merge pull request #130 from mitodl/feature/revert-129
2676f79 
Revert "Merge pull request #129 from mitodl/bug/gdm/111_performance"

unfixes #111 
[starts #101927046]
@pdpinch
Copy link
Member Author

pdpinch commented Sep 7, 2015

2a37338 was reverted so I'm opening this again.

@pdpinch pdpinch reopened this Sep 7, 2015
@pdpinch pdpinch modified the milestone: 8/29 Sprint Aug 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giocalitri giocalitri

Labels
P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ShawnMilo @pdpinch @giocalitri