-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Since Navigator 4.5.5 suddenly there's an underline color when metadata is filled #400
Comments
Hi @rubinatorz, Thanks for your comment! You're correct this was a purposeful change - to include an underline on a technique when it has metadata attached. This was a feature we'd previously had on the Navigator long ago, but it was dropped at some point. We re-added it to make it possible to see if metadata exists at a glance. To disable the metadata underline, you can change the Since we'd like to retain the underline feature for metadata, I'd propose that we add a new |
hi @clemiller I agree having a separate setting for the metadata underline is useful. However, in our opinion it's more useful to influence this settings via the layer JSON (LayerObject). DeTT&CT outputs JSON layers and when loading these you don't want to change the URL every time. We, and many people I guess, always use the Github hosted version of Navigator, so we are not able to use a custom config file. Regards, |
hi there!
Since latest 4.5.5 release of the Navigator, all layers suddenly have underlines for techniques:
Before this new Navigator version, you only get an underline when you have filled in a comment. But now, it will also give an underline when having metadata.
I see this is done on purpose in this commit:
bc4ad9f#diff-e49d1d934cc9d96bce820fb261164a66e14c3c90fa2364ff83b6d12201992182
There's now a function getTechniqueUnderlineColor that determines the underline when this condition is true:
tvm.comment.length > 0 || tvm.metadata.length > 0 || this.hasNotes()
Instead of only when no comment is filled in (how it was before):
<span [style.border-color]="configService.getFeature('comment_underline') ? configService.comment_color: ''" [style.color]="getTechniqueTextColor()">
This change has a huge impact. It makes Navigator layers, and thus also the layers of users using DeTT&CT, significantly less attractive and hence less usable for presenting results. See examples beneath how it looks like when you create layers with DeTT&CT.
We propose to undo this change of underlining. Or give a possibility to influence this.
Regards,
Ruben
The text was updated successfully, but these errors were encountered: