Invalidate entries instead of a collection #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Thanks again for this add-on, its really useful.
This PR updates the approach to invalidate Entries themselves rather than the Collection, which still results in the collection rules being triggered:(https:/statamic/cms/blob/801e954a054c0731e9890bb44be92970503cb6f9/src/StaticCaching/DefaultInvalidator.php#L62-L73)
The benefit of this is that you dont need to rely on rules for the invalidation - individual entry urls are invalidated regardless of whether they are in the rules.
If you're happy with this change, I'll raise a separate draft PR to support adding a query scope to the query (which relies on statamic/cms#5927 merging) which would allow dev's to add to the query (for example to add a
->orWhere('end_date', $now)
on certain collections). I had the code all written but forgot that hadn't merged to core yet!