HID: Avoid repeated error messages from hid_write()/hid_read()

[daschuer]

This is fixed the huge log file issue with #13660 for log spam in any disconnect case, without fixing the root cause in that particular case.

[acolombier]

LGTM! Thanks

Do we think this is a sufficient mitigation for the log file size till we have a proper limiter in place?

[JoergAtGithub]

This will not work as the comment describes. To ensure that only identical errors are inhibited, you need to compare the error message string.

[JoergAtGithub]

Same here

[daschuer]

I have adjusted the error message. We want also stop log spam in the unlikely case that there are altering different error messages, because this would still fill the log file.

[daschuer]

Do we think this is a sufficient mitigation for the log file size till we have a proper limiter in place?

I consider this a permanent solution, because we also want to avoid the performance impact, until the 100 MB log limit is from #13684 is reached.

[JoergAtGithub]

hid_write is also used here:

mixxx/src/controllers/hid/hidioglobaloutputreportfifo.cpp

Lines 68 to 76 in d6eeb45

	int result = hid_write(pHidDevice,
	reinterpret_cast<const unsigned char*>(reportToSend.constData()),
	reportToSend.size());
	if (result == -1) {
	qCWarning(logOutput) << "Unable to send data to" << deviceInfo.formatName() << ":"
	<< mixxx::convertWCStringToQString(
	hid_error(pHidDevice),
	kMaxHidErrorMessageSize);
	}

[JoergAtGithub]

Suggested change

	qCWarning(m_logOutput) << "Unable to read buffered HID InputReports from"
	<< m_deviceInfo.formatName() << ":"
	<< mixxx::convertWCStringToQString(
	hid_error(m_pHidDevice),
	kMaxHidErrorMessageSize);
	qCWarning(m_logOutput) << "Unable to read buffered HID InputReports from"
	<< m_deviceInfo.formatName() << ":"
	<< mixxx::convertWCStringToQString(
	hid_error(m_pHidDevice),
	kMaxHidErrorMessageSize)
	<< "Note that, this message is only logged once and may not appear again until all hid_read errors have disappeared.";

[daschuer]

Done