Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(POC) LateNight: allow to show 4 decks in a row #13724

Draft
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 7, 2024

A fun (two-) coffee break hack.
Looks okay, please test and let me know what you think.

image

TODO

  • apply to mini decks, too (library maximized)
  • adjust Classic theme

@github-actions github-actions bot added the skins label Oct 7, 2024
@ronso0 ronso0 force-pushed the late-4decks-row branch 2 times, most recently from 3303c10 to f422ed5 Compare October 7, 2024 16:14
@Eve00000
Copy link
Contributor

Eve00000 commented Oct 7, 2024

very nice!
only 2 coffees?

@ronso0
Copy link
Member Author

ronso0 commented Oct 7, 2024

Thanks. Nice, but not polished yet.
I'll try to move more components into templates and not add much complexity.

Yes, two flat white with sugar and a glass of water.

@ronso0
Copy link
Member Author

ronso0 commented Oct 7, 2024

FWIW, changing the deck order (3 1 2 4 or 1 2 3 4) can be done with color schemes and deck num variables, ie. requires skin reload to update the deck numbers in each deck/waveform template.

For LateNight we'd then have

  • PaleMoon (Decks 3 1 2 4) (default)
  • PaleMoon (Decks 1 2 3 4)
  • Classic (Decks 3 1 2 4)
  • Classic (Decks 1 2 3 4)

with almost exact duplicate themes.

Idk if that's worth it. Is this a desired feature? Idk.
If yes, the color scheme solution is definitely easier than adding a skin option (Interface preferences), with all the safety checks, can it be applied (does skin support 4 decks?) and what not.

@daschuer
Copy link
Member

daschuer commented Oct 8, 2024

The demand for 1234 is only sourced by certain controllers. With "wrong" labeling. right? Is switching between 3124 and 1234 a mapping feature? We need probably also swap the deck xfader orientation. Do we know which controller are affected?

@Eve00000
Copy link
Contributor

Eve00000 commented Oct 8, 2024

It's not only for certain controllers.
I don't want to offend people with what I'm writing.
There are people whose brain works a little different than the brain of most people. (Dyscalculy, acalcumy , obsessive compulsive disorder ...)
They can learn rows of numbers, letters etc but when numbers are not in the 'right' order, they stop functioning.
in other words: 1 2 3 4 is perfect, 4 3 2 1 is more difficult and mixed-up numbers are mixing them up as well. (also faders on a hardware mixer with 3 & 4 on the outside and 1 and 2 inside) Those people could only use Deck 1 & 2,, Now with a big screen and 1 2 3 4 they can use all 4 of them. They will be grateful.
Ronso, I'll buy you a coffee. :-)

@ronso0
Copy link
Member Author

ronso0 commented Oct 8, 2024

The demand for 1234 is only sourced by certain controllers. With "wrong" labeling. right?

Yes, probably. And we don't have deck number labels, but we do have the "LoadToDeck#" controls, and with external mixers one has to map mixer <--> Mixxx numbers twice: for the mapping and for the deck sound I/O configuration. Needs to be done only once, so yeah, maybe it's too much complexity considering the little demand.

@ronso0 ronso0 force-pushed the late-4decks-row branch 2 times, most recently from d286562 to 8865ca4 Compare October 10, 2024 22:22
@github-actions github-actions bot added the ui label Oct 10, 2024
@daschuer
Copy link
Member

Those people could only use Deck 1 & 2,, Now with a big screen and 1 2 3 4 they can use all 4 of them. They will be grateful.

I was not aware that a certain order prevents people from using deck 3 and 4. In general we should make all users feel at home with Mixxx. Unfortunately the issue is more complex that it may seem. We need to consider switching from:

1 2 
3 4 

To

1234

And take 1234 and 3124 labeled controllers into account. I consider a wrong labeling more a mental issue than a surprising order. So how about file an issue for that and solve it independently for all skins?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants