Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify three quantiles as required by corner 2.2.2 #298

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

johnveitch
Copy link
Collaborator

@johnveitch johnveitch commented Apr 13, 2023

#297 finds a problem with corner v2.2.2 where it expects three quantiles to be specified. This updates the nessai default quantiles to include the 50% one (the corner default).

Closes #297

@johnveitch johnveitch requested a review from mj-will April 13, 2023 13:22
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (8e75c84) 99.49% compared to head (9853fd6) 99.48%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   99.49%   99.48%   -0.02%     
==========================================
  Files          61       58       -3     
  Lines        4593     4497      -96     
==========================================
- Hits         4570     4474      -96     
  Misses         23       23              
Flag Coverage Δ
unittests 99.48% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nessai/plot.py 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@mj-will mj-will left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @johnveitch for addressing this. I'll try to make a bugfix release in the next couple of days with this change.

@mj-will mj-will merged commit b5f1953 into mj-will:main Apr 14, 2023
@mj-will mj-will mentioned this pull request Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nessai test suite fails with corner 2.2.2
3 participants