-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML Comments rendered with additional white space #2882
Comments
Did you tried to wrap in mj-raw those comment ? |
Yes, to temporarily fix it. But I would like to prefer it, that MJML doesn't modify the whitespace inside an HTML comment. |
Might be fixable as the space might be introduced by this https:/mjmlio/mjml/blob/master/packages/mjml-parser-xml/src/index.js#L315-L326 I'll check later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Currently, HTML comments get additional whitespace inside in the beginning and the end:
<!--#TEST-->
will be transformed to<!-- #TEST -->
. CleverReach uses HTML comments as a programming language and doesn't support a space or any other whitespace character between the start of the comment and the command (<!--#loop #-->
works,<!-- #loop # -->
not).To Reproduce
Steps to reproduce the behavior:
<mjml><!--#COMMAND#--></mjml>
Expected behavior
Preserving of no or all whitespaces in HTML comments.
MJML environment (please complete the following information):
The text was updated successfully, but these errors were encountered: