Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlazePose 3D keypoints #210

Open
shiffman opened this issue Oct 8, 2024 · 1 comment
Open

BlazePose 3D keypoints #210

shiffman opened this issue Oct 8, 2024 · 1 comment

Comments

@shiffman
Copy link
Member

shiffman commented Oct 8, 2024

I'm just opening an issue here to link to and track the discussion at ml5js/ml5-website-v02-docsify#181. It started as a documentation discussion but has moved towards ideas for changing the model output for the z values of the BlazePose model. See latest proposal: ml5js/ml5-website-v02-docsify#181 (comment). I think we can do these as "non-breaking" changes. I am also going to work on a new example showing how to use the z data.

@ziyuan-linn
Copy link
Member

I think we have three options:

  1. Remove the z values for the named keypoints:
nose: {
  x: 332.6024622758805,
  y: 265.78330263473146,
  confidence: 0.9993924452777454,
}
  1. Nest the 3d values in another object:
nose: {
  x: 332.6024622758805,
  y: 265.78330263473146,
  confidence: 0.9993924452777454,
  keypoint3D: {
    x: 0.05988978072436527,
    y: -0.5489126977664187,
    z: -0.26418375968933105,
    confidence:  0.9898926452717258
  }
}
  1. prepend the 3d values with 3d:
nose: {
  x: 332.6024622758805,
  y: 265.78330263473146,
  confidence: 0.9993924452777454,
  3dX: 0.05988978072436527,
  3dY: -0.5489126977664187,
  3dZ: -0.26418375968933105,
  3dConfidence:  0.9898926452717258
}

I agree this can be a non-breaking change since removing the z can be viewed as a bug fix. Perhaps it should be a minor change instead of a patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants