Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastpath inference is not supported #901

Open
bigtree2020 opened this issue Jun 25, 2024 · 2 comments
Open

fastpath inference is not supported #901

bigtree2020 opened this issue Jun 25, 2024 · 2 comments

Comments

@bigtree2020
Copy link

I found the fastpath inference seems not supported, which is an optimization in
https:/mlfoundations/open_clip/blob/main/src/open_clip/transformer.py#L224.

May I know what is the reason to avoid using this in the current impl?

@rwightman
Copy link
Collaborator

we kept it in default batch_first=False only because the original was like that, could change it around so that fastpath could work in inference cases...

@rwightman
Copy link
Collaborator

I merged low risk changes, but haven't touched the masking which will prevent fastpath from being used for the text transformer still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants