Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nnf_multi_head_attention_forward fix indices of input projection initialization bias. #1154

Merged
merged 3 commits into from
May 14, 2024

Conversation

cregouby
Copy link
Collaborator

@cregouby cregouby commented May 10, 2024

fix #1133

@cregouby cregouby marked this pull request as draft May 10, 2024 13:55
@cregouby cregouby marked this pull request as ready for review May 10, 2024 14:33
@cregouby cregouby changed the title fix indices translation from pytorch nnf_multi_head_attention_forward fix indices of input projection initialization bias. May 10, 2024
@dfalbel dfalbel force-pushed the bugfix/nnf_multihead_attention_idx branch from a1929d2 to 55af207 Compare May 14, 2024 13:23
@dfalbel dfalbel merged commit 0508611 into mlverse:main May 14, 2024
8 of 9 checks passed
@dfalbel
Copy link
Member

dfalbel commented May 14, 2024

Thanks @cregouby

@cregouby cregouby deleted the bugfix/nnf_multihead_attention_idx branch September 5, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nnf_multi_head_attention_forward (indices)
2 participants