Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sampling from normal #938

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Sampling from normal #938

merged 3 commits into from
Dec 8, 2022

Conversation

dfalbel
Copy link
Member

@dfalbel dfalbel commented Dec 8, 2022

correctly allow NULL generators, so we let libtorch internals handle seeds, etc for the normal sampling.

Fix #937

@dfalbel dfalbel added the lantern Use this label if your PR affects lantern so it's built in the CI label Dec 8, 2022
@dfalbel dfalbel mentioned this pull request Dec 8, 2022
Closed
@dfalbel dfalbel merged commit 816f46a into main Dec 8, 2022
@dfalbel dfalbel deleted the bugfix/repro-sample branch December 8, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lantern Use this label if your PR affects lantern so it's built in the CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

torch_manual_seed does not seem to work with $sample()
1 participant
@dfalbel