-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve build system #964
Merged
Improve build system #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfalbel
force-pushed
the
configure
branch
22 times, most recently
from
January 20, 2023 15:31
b8db88d
to
8107cf7
Compare
…red for correctly ignoring .Rbuildignore stuff.
…ndexes and other stuff.
- Use a composite action to install cudnn - Improve the build matrix organisation
run wflow in PR's Fix path to runner point to correct os. mark pre cxx11 use single quotes try to include one config Change matrix to include the precxx stuff. interpolate the input. Improve R setup. Add shell Don't install pandoc in a few scenarios. Fix installation path reference. install a few commands making sure sudo is installed. missign default shell set non interactive frontend. Fully refactor installation. Fix function name. Fix installation issues. setup parallel compilation for faster execution. Use helper functions to check arch. make sure the file exists before writing. create dirs recursively and make sure the file exists. Fix helper funs Escape quotes for Windows and R 3.6 Increase timeout by default and refer to functions using `utils::`. Fix URL for Windows. maybe use just bash commands Use different way to create the file. Use another way to create the file. Use another way to create the file. Process os_name for windows. Install everything into `lib` and install headers too. Make sure runtime and archive are also installed into lib. run lantern builds again. Add a comment. upload check results on error. On Linux install the correct rpath. Fix URL for sha named files. Try not building lantern. correct the os name Can't acess the matrix from matrix. fix if statement in action. add debug terminal. Find the correct download URL for lantern. Make correct name. typo Require a more recent version of cli. Depend on desc to query the DESCRIPTION file. Update documentation.
dfalbel
added
the
lantern
Use this label if your PR affects lantern so it's built in the CI
label
Jan 27, 2023
dfalbel
removed
the
lantern
Use this label if your PR affects lantern so it's built in the CI
label
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will greatly improve build system for torch.
This will create a single step build system, so users can, for example, install lantern directly from GitHub actions.
LANTERN_URL
andLIBTORCH_URL
you can specify custom paths for lantern builds and libtorch builds.