Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build system #964

Merged
merged 41 commits into from
Feb 1, 2023
Merged

Improve build system #964

merged 41 commits into from
Feb 1, 2023

Conversation

dfalbel
Copy link
Member

@dfalbel dfalbel commented Jan 19, 2023

This PR will greatly improve build system for torch.
This will create a single step build system, so users can, for example, install lantern directly from GitHub actions.

  • Configure and Makevars now allow for building lantern as part of the installation process. Ie, doing `BUILD_LANTERN=1 Rscript -e "install_github('mlverse/torch')" will now build Lantern from source, which greatly improves reproducibility.
  • All CI scripts are now unified in a single workflow, making it much easier to maintain in the future.
  • Installation more robust and configurable using variables like LANTERN_URL and LIBTORCH_URL you can specify custom paths for lantern builds and libtorch builds.

@dfalbel dfalbel force-pushed the configure branch 22 times, most recently from b8db88d to 8107cf7 Compare January 20, 2023 15:31
run wflow in PR's

Fix path to runner

point to correct os.

mark pre cxx11

use single quotes

try to include one config

Change matrix to include the precxx stuff.

interpolate the input.

Improve R setup.

Add shell

Don't install pandoc in a few scenarios.

Fix installation path reference.

install a few commands making sure sudo is installed.

missign default shell

set non interactive frontend.

Fully refactor installation.

Fix function name.

Fix installation issues.

setup parallel compilation for faster execution.

Use helper functions to check arch.

make sure the file exists before writing.

create dirs recursively and make sure the file exists.

Fix helper funs

Escape quotes for Windows and R 3.6

Increase timeout by default and refer to functions using `utils::`.

Fix URL for Windows.

maybe use just bash commands

Use different way to create the file.

Use another way to create the file.

Use another way to create the file.

Process os_name for windows.

Install everything into `lib` and install headers too.

Make sure runtime and archive are also installed into lib.

run lantern builds again.

Add a comment.

upload check results on error.

On Linux install the correct rpath.

Fix URL for sha named files.

Try not building lantern.

correct the os name

Can't acess the matrix from matrix.

fix if statement in action.

add debug terminal.

Find the correct download URL for lantern.

Make correct name.

typo

Require a more recent version of cli.

Depend on desc to query the DESCRIPTION file.

Update documentation.
@dfalbel dfalbel added the lantern Use this label if your PR affects lantern so it's built in the CI label Jan 27, 2023
@dfalbel dfalbel removed the lantern Use this label if your PR affects lantern so it's built in the CI label Jan 30, 2023
@dfalbel dfalbel merged commit 716dc41 into main Feb 1, 2023
@dfalbel dfalbel deleted the configure branch February 1, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant