Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Instant stackblitz demo #136

Merged
merged 7 commits into from
Sep 2, 2024
Merged

⚡ Instant stackblitz demo #136

merged 7 commits into from
Sep 2, 2024

Conversation

brunobuddy
Copy link
Contributor

@brunobuddy brunobuddy commented Aug 8, 2024

Description

This PR creates a working demo in Stackblitz that will be used as main demo for the Manifest project.

This main demo is now part of the mnfst/manifest repository for better update management. It is located under the /examples folder.

⚠️ There are several things that I could not manage to do for better DX. The most important missing feature is the pre-filled credentials in the admin panel.

🟠 Deployment: redirect manifest.new to the master branch after merge @brunobuddy

How can it be tested?

Click on that button:
Open in StackBlitz

Or use the "new" link: manifest.new.

Play around with the demo. The example project should be simple and give a proper idea of Manifest features and philosophy at the same time.

Impacted packages

Check the packages that require a new publication or release:

  • @mnfst/manifest
  • @mnfst/types
  • @mnfst/admin
  • doc

Check list before submitting

  • I have performed a self-review of my code (no debugs, no commented code, good naming, etc.)
  • I wrote the relative tests
  • I updated the documentation if necessary
  • This PR is wrote in a clear language and correctly labeled

@brunobuddy brunobuddy added the enhancement New feature or request label Aug 8, 2024
@brunobuddy brunobuddy self-assigned this Aug 8, 2024
Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
manifest-schema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 8:44am

@brunobuddy brunobuddy marked this pull request as ready for review August 8, 2024 10:45
@brunobuddy brunobuddy changed the title Instant stackblitz demo ⚡ Instant stackblitz demo Aug 8, 2024
@SebConejo
Copy link
Contributor

SebConejo commented Aug 26, 2024

@brunobuddy I have added the credentials to the README. I know they are already mentioned in the backend.yml file, but I didn’t expect to see them there. You neither as you told me "it's already written in the readme".

Other point: The url to the API appears only on the console. It's not enough visible. But I didn't find any solution as it's not a simple link.

@brunobuddy brunobuddy merged commit e52a312 into develop Sep 2, 2024
5 checks passed
@brunobuddy brunobuddy deleted the feature/demo-stackblitz branch September 2, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants