Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lazy Package Loads #14

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

matthewphsmith
Copy link

@matthewphsmith matthewphsmith commented Jul 29, 2019

Proposed fix to issue: #15

  • Ensure that when a package of a lazy-loaded module is loaded, the
    lazy-loaded module remains an attribute of the newly loaded package.
  • Ensure that when two lazy-loaded modules exist in the same lazy package,
    the second (and all subsequent) lazy-modules are also added to the lazy
    package's list of lazy sub-modules.

reload does not have the desired behavior. Since when the import is triggered it is actually the first import, it is preferable to use the importlib.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant