Feature rating sites #112
Closed
Feature rating sites #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadi-norouzi
force-pushed
the
feature/rating_sites
branch
from
b6f0245
to
d6dfd27
Compare
moallemi
approved these changes
Sep 23, 2024
| icon = R.drawable.ic_imdb, | ||
| rate = "${rate.rating}", | ||
| votes = ratings.imdb?.votes ?: "N/A", | ||
| onClick = rate.link?.let { { onRatingClick(rate.link!!) } }, |
There was a problem hiding this comment.
- Why do not we handle the link click and hoist this url to parent composable while we can sort it out here?
- Please try to avoid using !! as much as possible. Although in this case rate.link!! will never be null, it takes time for someone reading the code to understand why. They might need to verify whether a null case is possible and if an exception could be thrown. Using a safer approach can make the code more readable and maintainable.
Suggested change
| onClick = rate.link?.let { { onRatingClick(rate.link!!) } }, | |
| onClick = rate.link?.let { { onRatingClick(it) } }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly.
Take a look at the contributing guidelines for this project.
Description
Checklist
Fixes #109