-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.11 backport] azblob and s3 integration tests #4030
Merged
crazy-max
merged 7 commits into
moby:v0.11
from
crazy-max:v0.11_backport_test-azblob-minio
Jul 20, 2023
Merged
[0.11 backport] azblob and s3 integration tests #4030
crazy-max
merged 7 commits into
moby:v0.11
from
crazy-max:v0.11_backport_test-azblob-minio
Jul 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <[email protected]> (cherry picked from commit 3d93d64)
Signed-off-by: CrazyMax <[email protected]> (cherry picked from commit c03ccb8)
Signed-off-by: CrazyMax <[email protected]> (cherry picked from commit 35e870d)
Signed-off-by: CrazyMax <[email protected]> (cherry picked from commit 05c4d57)
Signed-off-by: CrazyMax <[email protected]> (cherry picked from commit 54695a3)
Signed-off-by: CrazyMax <[email protected]> (cherry picked from commit 2f8b5e7)
1 task
Looks like some failures; do we know what's causing them? |
Oh didn't catch this, I will take a look
|
By default account name is parsed from request uri host (account url) but when product style url is disabled, account name is not part of the host. This new attribute allows to specify the account name in such case. Also return error if account name is empty. Signed-off-by: CrazyMax <[email protected]>
thaJeztah
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, nice!
"LGTM" (because CI is green, not because I know anything about these changes 🙈)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix tests related to #3884 (comment)