Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResolveImageConfig: Only fetch best matching config #4311

Merged
merged 1 commit into from
Oct 13, 2023
Merged

ResolveImageConfig: Only fetch best matching config #4311

merged 1 commit into from
Oct 13, 2023

Commits on Oct 13, 2023

  1. ResolveImageConfig: Only fetch best matching config 

    Before this change, all platforms that loosely match the provided
platform will be fetched even though we only care about 1 of them.
As an example when linux/amd64 is requested it will also fetch linux/386
because it is a compatible architecture.
This means extra round trips to the registry, potentially even for
content that doesn't exist in the remote.

This is especially a problem when resolve mode is prefer-local because
we'll have the index locally but most likely only one manifest.
In this case we'll end up reaching out to the registry to fetch the
other manifests unncessarily.

With this change instead of fetching all matching platforms it chooses
only the best matching platform.

Signed-off-by: Brian Goff <[email protected]>
    @cpuguy83 @jedevc
    cpuguy83 authored and jedevc committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    575cb10 View commit details
    Browse the repository at this point in the history