gateway: restore original filename in StatFile error message #4321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to 38040ae. Messages returned by fsutil.Stat are guaranteed to return a PathError wrapped by a stack trace (since it calls os.Lstat). However, as these error messages are printed, they include the temporary directory for the mounted reference which is not useful to the caller. On an error, we can restore the filename in the PathError to the requested filename, as also seen in os.DirFS. Signed-off-by: Justin Chadwell <[email protected]>
tonistiigi
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3990, but this time for
StatFileas well.Messages returned by
fsutil.Statare guaranteed to return aPathErrorwrapped by a stack trace (since it callsos.Lstat). However, as these error messages are printed, they include the temporary directory for the mounted reference which is not useful to the caller.On an error, we can restore the filename in the
PathErrorto the requested filename, as also seen inos.DirFS.